Skip to content

Fix #21: Fix Windows unlink() for "read only" files #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix #21: Fix Windows unlink() for "read only" files #25

wants to merge 1 commit into from

Conversation

samdark
Copy link
Member

@samdark samdark commented Nov 9, 2020

Q A
Is bugfix? ✔️
New feature? ❌
Breaks BC? ❌
Fixed issues #21

@samdark samdark added type:bug Bug status:code review The pull request needs review. labels Nov 9, 2020
@samdark samdark requested review from vjik and a team November 9, 2020 06:59
@samdark samdark mentioned this pull request Nov 9, 2020
Merged
vjik
vjik approved these changes Nov 9, 2020
View reviewed changes
Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. I'm use this in PR #24

@samdark samdark closed this Nov 10, 2020
@samdark samdark deleted the fix-windows-unlink branch November 10, 2020 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vjik vjik vjik approved these changes

Assignees
No one assigned
Labels
status:code review The pull request needs review. type:bug Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samdark @vjik