Skip to content

Add IDE autocomplete hints #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 27, 2021
Merged

Add IDE autocomplete hints #253

merged 9 commits into from
Sep 27, 2021

Conversation

SOHELAHMED7
Copy link
Contributor

Q A
Is bugfix? no
New feature? no
Breaks BC? no
Tests pass? yes
Fixed issues #216

@bizley
Copy link
Member

bizley commented Sep 13, 2021

Shouldn't it be rather suggested in the documentation? There are some fixed implementations that are not necessarily true in every case.

@cebe
Copy link
Member

cebe commented Sep 13, 2021

This is an application template so code is expected to be adjusted. We can explain that in the phpdoc comments.

cebe
cebe requested changes Sep 13, 2021
View reviewed changes
cebe
cebe reviewed Sep 13, 2021
View reviewed changes
@bizley
Copy link
Member

bizley commented Sep 13, 2021

This is an application template so code is expected to be adjusted. We can explain that in the phpdoc comments.

Yes, so let's keep what is usually set the way it's placed here and remove what is non-standard like yii\queue\redis\Queue $queue.

@cebe
Copy link
Member

cebe commented Sep 13, 2021

This is an application template so code is expected to be adjusted. We can explain that in the phpdoc comments.

Yes, so let's keep what is usually set the way it's placed here and remove what is non-standard like yii\queue\redis\Queue $queue.

oh, right. did not see the queue entry.

samdark
samdark reviewed Sep 13, 2021
View reviewed changes
SOHELAHMED7 and others added 4 commits September 21, 2021 14:17
@SOHELAHMED7 @cebe
Update config/__autocomplete.php
b4963c2 
Co-authored-by: Carsten Brandt <mail@cebe.cc>
@SOHELAHMED7 @cebe
Update config/__autocomplete.php
a70c405 
Co-authored-by: Carsten Brandt <mail@cebe.cc>
@SOHELAHMED7 @cebe
Update config/__autocomplete.php
f472519 
Co-authored-by: Carsten Brandt <mail@cebe.cc>
@SOHELAHMED7
Update __autocomplete.php
a2bd73f
@SOHELAHMED7
Copy link
Contributor Author

All feedback applied

@samdark samdark merged commit 0326819 into yiisoft:master Sep 27, 2021
@samdark
Copy link
Member

samdark commented Sep 27, 2021

Thanks! Would you please apply the same to advanced app template?

@SOHELAHMED7
Copy link
Contributor Author

Thanks! Would you please apply the same to advanced app template?

Yes

SOHELAHMED7 added a commit to SOHELAHMED7/yii2-app-advanced that referenced this pull request Nov 4, 2021
@SOHELAHMED7
Create __autocomplete.php
a2465af 
Add IDE autocomplete hints yiisoft#253

Similar to  yiisoft/yii2-app-basic#253 for yii2-advanced app
@SOHELAHMED7 SOHELAHMED7 mentioned this pull request Nov 4, 2021
Merged
samdark pushed a commit to yiisoft/yii2-app-advanced that referenced this pull request Nov 4, 2021
@SOHELAHMED7
Create __autocomplete.php (#512)
e91c065 
Add IDE autocomplete hints #253

Similar to  yiisoft/yii2-app-basic#253 for yii2-advanced app
neverabe added a commit to ROAResearch/yii2-app-roa that referenced this pull request Jan 5, 2023
@agSoftDUCK @samdark
@Naktibalda @SamMousa @amin3mej @rob006 @RichardPillay @softark @fleduc @kmindi @WadeShuler @DeryabinSergey @HA3IK @GelvardMann @terabytesoftw @yusupovgiyos @Faryshta @mgafur @ditibal @machour @toir427 @SOHELAHMED7 @githubjeka @developedsoftware @themikem @dehbka @juppwerner @oathsign @neverabe
Php8 as minor requirement (#3)
413c798 
* Remove github from funding options [skip ci]

* release version 2.0.22

* prepare for next release

* Update codeception/verify to 1.1.0 (#436)

And use stringContainsString() instead of contains(), because assertContains with string haystacks is deprecated in PHPUnit 8

* Fix typo (#441) [skip ci]

* Fix PHP 5.6 compatibility (#442)

* Fix #440: Corrected PHP version requirement

* release version 2.0.26

* prepare for next release

* Add phpdoc to User::generateEmailVerificationToken() [skip ci]

* Use modular Codeception 4.0 (#449)

* Migrate Travis from .org to .com

* release version 2.0.27

* prepare for next release

* release version 2.0.31

* prepare for next release

* Adjust docs for new PHP requirement. (#451)

* Update testing database description in start-testing.md [skip ci]

As a someone new to Yii, PHP and automated testing,  the purpose of some of these steps was not obvious. Hopefully this will help other new users without adding too much noise for more experienced users.

Co-authored-by: Alexander Makarov <sam@rmcreative.ru>

* Update Japanese docs on testing [ci skip] (#456)

* Remove version restriction for PHPUnit (#455)

This template does not use PHPUnit directly,
It uses Codeception and it is responsibility of Codeception to manage compatibility with PHPUnit.
Also there is no such restriction in basic app.

* Fix deprecation messages

Moved _bootstrap out of settings - it's use in Settings has been Deprecated

* release version 2.0.32

* prepare for next release

* Update start-installation.md in regards to issues #457 and #458 (#459)

Issue #457 is about placing 'php' within the docker command
and issue #458 is about inverting commands

* release version 2.0.33

* prepare for next release

* release version 2.0.34

* prepare for next release

* release version 2.0.35

* prepare for next release

* Increase default minimum password length to 12 (#465)

* Add missing class to urlManagerFrontend (#467)

On custom named url managers, the `class` element is required. You will get a `Invalid Configuration` exception without it!

* docs/guide-ja updated [ci skip] (#469)

* Add more detail to "Creating links from backend to frontend" guide

* Update meta

* release version 2.0.36

* prepare for next release

* Standartize minimal password length by config param user.passwordMinLength #471 (#472)

* release version 2.0.37

* prepare for next release

* Japanese Guide Updated [ci skip] (#476)

* Add minimal center layout and login form (#478)

* Enh: Add virtual machine IP to the Yii2 Advanced "allowedIPs" (#480)

* Bug: Vagrant installation was stopping on each missing plugin

* Fix #215: Remove files from other env which not exists in current env (#479)

* release version 2.0.38

* prepare for next release

* Add missing div tag (#483)

* Switch to GitHub actions

* Remove unsed code coverage. (#485)

* release version 2.0.39

* prepare for next release

* Update pipline syntax

* Fix #489: Bump docker container version to 7.4

* release version 2.0.40

* prepare for next release

* Invalidate authentication key on password change

* release version 2.0.41

* prepare for next release

* release version 2.0.42

* prepare for next release

* Update Gii (#500)

* composer requirements for php8

* Use Bootstrap 4 (#501)

* calibrate test environment

* docs/guide-ja/start-installation.md updated

* release version 2.0.43

* prepare for next release

* Update layout (#506)

Make Navbar menu position as right

* Fix #502: Update php and ubuntu version in vagrant stack (#507)

* Fix typo in SECURITY.md [skip ci]

* Fix typo (#509)

* Create __autocomplete.php (#512)

Add IDE autocomplete hints #253

Similar to  yiisoft/yii2-app-basic#253 for yii2-advanced app

* release version 2.0.44

* prepare for next release

* docs: correct Syntax for phpDoc (#515)

Co-authored-by: githubjeka <etcoder@gmail.com>

* release version 2.0.45

* prepare for next release

* Make tests compatible with PHP 8.1 and Codeception 5 (#518)

* Update to PHP 7.4 and codeception/verify 2.2 (#521)

* Update advanced template to Bootstrap 5 & remove deprecated swiftmailer package (#516)

Co-authored-by: Luke English <luke@developedsoftware.com>

* className() is deprecated - switch to ::class (#522)

* Include init into vagrant installation instructions

* Update composer depedencies to work with Codeception 5 (#523)

* replace "codeception/codeception": "^5.0.0-alpha2" with "codeception/codeception": "^5.0.0"

* update yii2 codeception module as its now a proper release (1.1.6)

* release version 2.0.46

* prepare for next release

* Fix #529: Remove composer.lock from .gitignore (#530)

* Use https urls for yiiframework.com

* Fix namespaces in IDE for codeception (#532)

* Dockerfiles: Changed to yii2-php:8.1-apache (#534)

* Fixed docs/guide-zh-CN/start-installation.md

Add missing text

* upgrade scripts and add production validation

* fix truncate

* test for no _links request

* Update main.php

* Update build.yml

* Update composer.json

Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
Co-authored-by: Gintautas Miselis <naktibalda@gmail.com>
Co-authored-by: Sam <sam@mousa.nl>
Co-authored-by: Gintautas Miselis <gintautas@miselis.lt>
Co-authored-by: S.M.A. Djawadi <amin3mej@gmail.com>
Co-authored-by: Robert Korulczyk <robert@korulczyk.pl>
Co-authored-by: Richard Pillay <RichardPillay@Yahoo.co.uk>
Co-authored-by: Nobuo Kihara <softark@gmail.com>
Co-authored-by: fleduc <fleduc.perso@gmail.com>
Co-authored-by: Kai Mindermann, M.Sc <kai.mindi@gmx.de>
Co-authored-by: Wade <WadeShuler@users.noreply.github.com>
Co-authored-by: Deryabin Sergey <deryabinsergey@gmail.com>
Co-authored-by: Nazar Holubovskyy <golubha3ik@gmail.com>
Co-authored-by: Тимофей <47164430+GelvardMann@users.noreply.github.com>
Co-authored-by: Wilmer Arambula <42547589+terabytesoftw@users.noreply.github.com>
Co-authored-by: sinus <sinus_22@mail.ru>
Co-authored-by: Faryshta <angeldelcaos@gmail.com>
Co-authored-by: Bizley <pawel@positive.codes>
Co-authored-by: mgafur <mgafur@gmail.com>
Co-authored-by: Andrew <ditibal@gmail.com>
Co-authored-by: Mehdi Achour <machour@gmail.com>
Co-authored-by: Toir Tuychiev <toir427@gmail.com>
Co-authored-by: Sohel Ahmed Mesaniya <sam.wankaner@gmail.com>
Co-authored-by: Evgeniy Tkachenko <et.coder@gmail.com>
Co-authored-by: githubjeka <etcoder@gmail.com>
Co-authored-by: Luke English <luke@developedsoftware.com>
Co-authored-by: themikem <ke5czk@gmail.com>
Co-authored-by: Denys Moskovchenko <dehbkaa@gmail.com>
Co-authored-by: Jo Werner <joachim.werner@diggin-data.de>
Co-authored-by: 誓言之印 <hhzgq@163.com>
Co-authored-by: Carlos Llamosas <cmllamosas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cebe cebe cebe requested changes

@samdark samdark samdark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SOHELAHMED7 @bizley @cebe @samdark