Refactored & factorized the way jobs are executed (#59)

* Refactored & factorized the way jobs are executed

* Fixed PHP 8.0 array with keys unpack

* Fixed checkstyle

* Add missing JobContainer class comment

* Add test case to prove status can be changed by event listeners

* Fixed summary log array_merge

* Simplified integration tests jobs building

* Use PHP 8 promoted properties in JobContainer

* Fixed docs after refactoring

Author: yann-eugone

src/Resources/services/global/alias.xml

@@ -13,6 +13,12 @@
         <service id="Yokai\Batch\Registry\JobRegistry"
                  alias="yokai_batch.job_registry"/>
 
+        <service id="Yokai\Batch\Job\JobExecutionAccessor"
+                 alias="yokai_batch.job_execution_accessor"/>
+
+        <service id="Yokai\Batch\Job\JobExecutor"
+                 alias="yokai_batch.job_executor"/>
+
         <service id="Yokai\Batch\Factory\JobExecutionIdGeneratorInterface"
                  alias="yokai_batch.job_execution_id_generator.uniqid"/>
     </services>

src/Resources/services/global/core.xml

@@ -0,0 +1,36 @@
+<?xml version="1.0" ?>
+
+<container xmlns="http://symfony.com/schema/dic/services"
+           xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+           xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd">
+
+    <services>
+        <defaults public="false"/>
+
+        <service id="yokai_batch.job_execution_factory"
+                 class="Yokai\Batch\Factory\JobExecutionFactory">
+            <argument type="service" id="Yokai\Batch\Factory\JobExecutionIdGeneratorInterface"/>
+        </service>
+
+        <service id="yokai_batch.job_registry"
+                 class="Yokai\Batch\Registry\JobRegistry">
+            <argument/>
+        </service>
+
+        <service id="yokai_batch.job_execution_accessor"
+                 class="Yokai\Batch\Job\JobExecutionAccessor">
+            <argument type="service" id="yokai_batch.job_execution_factory"/>
+            <argument type="service" id="Yokai\Batch\Storage\JobExecutionStorageInterface"/>
+        </service>
+
+        <service id="yokai_batch.job_executor"
+                 class="Yokai\Batch\Job\JobExecutor">
+            <argument type="service" id="yokai_batch.job_registry"/>
+            <argument type="service" id="Yokai\Batch\Storage\JobExecutionStorageInterface"/>
+            <argument type="service" id="event_dispatcher" on-invalid="null"/>
+        </service>
+
+        <service id="yokai_batch.job_execution_id_generator.uniqid"
+                 class="Yokai\Batch\Factory\UniqidJobExecutionIdGenerator"/>
+    </services>
+</container>

src/Resources/services/global/factory.xml

@@ -9,10 +9,8 @@
 
         <service id="yokai_batch.job_launcher.simple"
                  class="Yokai\Batch\Launcher\SimpleJobLauncher">
-            <argument type="service" id="yokai_batch.job_registry"/>
-            <argument type="service" id="yokai_batch.job_execution_factory"/>
-            <argument type="service" id="Yokai\Batch\Storage\JobExecutionStorageInterface"/>
-            <argument type="service" id="event_dispatcher" on-invalid="null"/>
+            <argument type="service" id="yokai_batch.job_execution_accessor"/>
+            <argument type="service" id="yokai_batch.job_executor"/>
         </service>
     </services>
 </container>

src/Resources/services/global/launcher.xml

@@ -9,7 +9,8 @@
 
         <service id="yokai_batch.run_job_command"
                  class="Yokai\Batch\Bridge\Symfony\Console\RunJobCommand">
-            <argument type="service" id="yokai_batch.job_launcher.simple"/>
+            <argument type="service" id="yokai_batch.job_execution_accessor"/>
+            <argument type="service" id="yokai_batch.job_executor"/>
             <tag name="console.command"/>
         </service>
     </services>

src/Resources/services/global/registry.xml

@@ -4,12 +4,12 @@
 
 namespace Yokai\Batch\Tests\Bridge\Symfony\Framework\Fixtures;
 
-use Yokai\Batch\Job\AbstractJob;
+use Yokai\Batch\Job\JobInterface;
 use Yokai\Batch\JobExecution;
 
-final class DummyJob extends AbstractJob
+final class DummyJob implements JobInterface
 {
-    protected function doExecute(JobExecution $jobExecution): void
+    public function execute(JobExecution $jobExecution): void
     {
         // dummy
     }

src/Resources/services/symfony/console/command.xml

@@ -5,17 +5,17 @@
 namespace Yokai\Batch\Tests\Bridge\Symfony\Framework\Fixtures;
 
 use Yokai\Batch\Bridge\Symfony\Framework\JobWithStaticNameInterface;
-use Yokai\Batch\Job\AbstractJob;
+use Yokai\Batch\Job\JobInterface;
 use Yokai\Batch\JobExecution;
 
-final class DummyJobWithName extends AbstractJob implements JobWithStaticNameInterface
+final class DummyJobWithName implements JobInterface, JobWithStaticNameInterface
 {
     public static function getJobName(): string
     {
         return 'export_orders_job';
     }
 
-    protected function doExecute(JobExecution $jobExecution): void
+    public function execute(JobExecution $jobExecution): void
     {
         // dummy
     }