Raise code coverage to 100% (#39)

* Implemented an in memory job execution storage

* Covered event dispatching & not executable job executions

* Added tests to cover events

* Added tests that covers configurable elements helper traits

* Added tests for AbstractJob

* Add more tests to cover items expand

* Add more test to cover edge cases on job execution serialization

* Add more tests to cover edge cases of filesystem job execution storage

* Add tests to cover NullJobExecutionStorage

* Add tests to cover QueryBuilder & Query

* Removed unused exception parts

* Add more tests to cover DoctrineDBALJobExecutionStorage

* Add way more test to cover JobExecutionRowNormalizer via DoctrineDBALJobExecutionStorage

* Cover all edge cases of symfony/console bridge

* Cover all edge cases of symfony/framework-bundle bridge

* Cover all edge cases of symfony/validator bridge

* Fixed compatibility of symfony/validator bridge tests with Symfony 4.x

* Create readonly filesystem storage dir at runtime

* Fixed static analysis & checkstyle issues

Author: yann-eugone

src/DependencyInjection/YokaiBatchExtension.php

@@ -60,11 +60,8 @@ public function load(array $configs, ContainerBuilder $container): void
 
     private function installed(string $package): bool
     {
-        if (InstalledVersions::isInstalled('yokai/batch-src')) {
-            return true;
-        }
-
-        return InstalledVersions::isInstalled('yokai/batch-' . $package);
+        return InstalledVersions::isInstalled('yokai/batch-src')
+            || InstalledVersions::isInstalled('yokai/batch-' . $package);
     }
 
     private function getLoader(ContainerBuilder $container): ConfigLoader\LoaderInterface
@@ -126,17 +123,18 @@ private function configureStorage(ContainerBuilder $container, array $config): v
             );
         }
 
-        $interfaces = [
-            JobExecutionStorageInterface::class => true,
-            ListableJobExecutionStorageInterface::class => false,
-            QueryableJobExecutionStorageInterface::class => false,
-        ];
         $defaultStorageClass = $defaultStorageDefinition->getClass();
         if ($defaultStorageClass === null) {
             throw new LogicException(
                 \sprintf('Job execution storage service "%s", has no class.', $defaultStorage)
             );
         }
+
+        $interfaces = [
+            JobExecutionStorageInterface::class => true,
+            ListableJobExecutionStorageInterface::class => false,
+            QueryableJobExecutionStorageInterface::class => false,
+        ];
         foreach ($interfaces as $interface => $required) {
             if (!is_a($defaultStorageClass, $interface, true)) {
                 if ($required) {

tests/DependencyInjection/YokaiBatchExtensionTest.php

@@ -4,8 +4,10 @@
 
 namespace Yokai\Batch\Tests\Bridge\Symfony\Framework\DependencyInjection;
 
+use Exception;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
+use Symfony\Component\DependencyInjection\Exception\LogicException;
 use Yokai\Batch\Bridge\Symfony\Framework\DependencyInjection\YokaiBatchExtension;
 use Yokai\Batch\Launcher\JobLauncherInterface;
 use Yokai\Batch\Storage\JobExecutionStorageInterface;
@@ -40,4 +42,43 @@ public function configs(): \Generator
         yield [['storage' => ['dbal' => null]], 'yokai_batch.storage.dbal'];
         yield [['storage' => ['service' => 'app.yokai_batch.storage']], 'app.yokai_batch.storage'];
     }
+
+    /**
+     * @dataProvider errors
+     */
+    public function testErrors(array $config, ?callable $configure, Exception $error): void
+    {
+        $this->expectExceptionObject($error);
+
+        $container = new ContainerBuilder();
+        if ($configure !== null) {
+            $configure($container);
+        }
+
+        (new YokaiBatchExtension())->load([$config], $container);
+    }
+
+    public function errors(): \Generator
+    {
+        yield 'Storage : Unknown service' => [
+            ['storage' => ['service' => 'unknown.service']],
+            null,
+            new LogicException('Configured default job execution storage service "unknown.service" does not exists.'),
+        ];
+        yield 'Storage : Service with no class' => [
+            ['storage' => ['service' => 'service.with.no.class']],
+            fn(ContainerBuilder $container) => $container->register('service.with.no.class'),
+            new LogicException('Job execution storage service "service.with.no.class", has no class.'),
+        ];
+        yield 'Storage : Service without required interface' => [
+            ['storage' => ['service' => 'service.without.required.interface']],
+            fn(ContainerBuilder $container) => $container->register('service.without.required.interface', __CLASS__),
+            new LogicException(
+                'Job execution storage service "service.without.required.interface",' .
+                ' is of class' .
+                ' "Yokai\Batch\Tests\Bridge\Symfony\Framework\DependencyInjection\YokaiBatchExtensionTest",' .
+                ' and must implements interface "Yokai\Batch\Storage\JobExecutionStorageInterface".'
+            ),
+        ];
+    }
 }