Enhanced code style (#113)

* Forbid yoda style condition

* Enforce maximum line length

* Enforce trailing slash on native functions invocation

Author: yann-eugone

src/DependencyInjection/Configuration.php

@@ -110,7 +110,7 @@ private function ui(): ArrayNodeDefinition
                     ->addDefaultsIfNotSet()
                     ->beforeNormalization()
                         ->always(function (string|array $value) {
-                            if (is_string($value)) {
+                            if (\is_string($value)) {
                                 $value = match ($value) {
                                     'bootstrap4' => ['prefix' => '@YokaiBatch/bootstrap4', 'service' => null],
                                     'sonata' => ['service' => 'yokai_batch.ui.sonata_templating', 'prefix' => null],

src/DependencyInjection/YokaiBatchExtension.php

@@ -56,7 +56,7 @@ public function load(array $configs, ContainerBuilder $container): void
             'symfony/validator/' => $this->installed('symfony-validator'),
         ];
 
-        foreach (array_keys(array_filter($bridges)) as $resource) {
+        foreach (\array_keys(\array_filter($bridges)) as $resource) {
             $loader->load($resource);
         }
 
@@ -127,7 +127,7 @@ private function configureStorage(ContainerBuilder $container, array $config): v
             $defaultStorageDefinition = $container->getDefinition($defaultStorage);
         } catch (ServiceNotFoundException $exception) {
             throw new LogicException(
-                sprintf('Configured default job execution storage service "%s" does not exists.', $defaultStorage),
+                \sprintf('Configured default job execution storage service "%s" does not exists.', $defaultStorage),
                 0,
                 $exception
             );
@@ -146,7 +146,7 @@ private function configureStorage(ContainerBuilder $container, array $config): v
             QueryableJobExecutionStorageInterface::class => false,
         ];
         foreach ($interfaces as $interface => $required) {
-            if (!is_a($defaultStorageClass, $interface, true)) {
+            if (!\is_a($defaultStorageClass, $interface, true)) {
                 if ($required) {
                     throw new LogicException(
                         \sprintf(
@@ -207,7 +207,7 @@ private function configureUserInterface(ContainerBuilder $container, LoaderInter
                 }
             } catch (ServiceNotFoundException $exception) {
                 throw new LogicException(
-                    sprintf('Configured UI templating service "%s" does not exists.', $templating['service']),
+                    \sprintf('Configured UI templating service "%s" does not exists.', $templating['service']),
                     0,
                     $exception
                 );

src/UserInterface/Form/JobFilterType.php

@@ -39,7 +39,7 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
             ChoiceType::class,
             [
                 'label' => 'job.field.job_name',
-                'choice_label' => fn($choice, string $key, $value) => sprintf('job.job_name.%s', $key),
+                'choice_label' => fn($choice, string $key, $value) => \sprintf('job.job_name.%s', $key),
                 'choices' => \array_combine($this->jobs, $this->jobs),
                 'required' => false,
                 'multiple' => true,
@@ -50,7 +50,7 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
             ChoiceType::class,
             [
                 'label' => 'job.field.status',
-                'choice_label' => fn($choice, string $key, $value) => sprintf('job.status.%s', $key),
+                'choice_label' => fn($choice, string $key, $value) => \sprintf('job.status.%s', $key),
                 'choices' => self::STATUSES,
                 'required' => false,
                 'multiple' => true,

tests/DependencyInjection/YokaiBatchExtensionTest.php

@@ -22,8 +22,13 @@ class YokaiBatchExtensionTest extends TestCase
     /**
      * @dataProvider configs
      */
-    public function test(array $config, ?callable $configure, string $storage, ?callable $templating, ?array $security): void
-    {
+    public function test(
+        array $config,
+        ?callable $configure,
+        string $storage,
+        ?callable $templating,
+        ?array $security
+    ): void {
         $container = new ContainerBuilder();
         if ($configure !== null) {
             $configure($container);

tests/UserInterface/Controller/JobControllerTest.php

@@ -234,7 +234,9 @@ public static function view(): \Generator
                         new JobParameters(['type' => 'complete']),
                         new Summary(['count' => 156]),
                     );
-                    $exportExecution->addWarning(new Warning('Skipped suspicious record', [], ['suspicious_record' => 2]));
+                    $exportExecution->addWarning(
+                        new Warning('Skipped suspicious record', [], ['suspicious_record' => 2])
+                    );
                     $exportExecution->addFailure(new Failure('RuntimeException', 'Missing record #2', 0));
                     $exportExecution->setStartTime(new \DateTimeImmutable('2021-01-01 10:00'));
                     $exportExecution->setEndTime(new \DateTimeImmutable('2021-01-01 11:00'));
@@ -516,7 +518,9 @@ private static function fixtures(int $count, array $attributes = []): void
                         BatchStatus::FAILED,
                     ])),
                     'startTime' => $start = (new \DateTimeImmutable())->setTimestamp(\random_int(0, \time() - 10)),
-                    'endTime' => (new \DateTimeImmutable())->setTimestamp(\random_int($start->getTimestamp(), \time() - 10)),
+                    'endTime' => (new \DateTimeImmutable())->setTimestamp(
+                        \random_int($start->getTimestamp(), \time() - 10)
+                    ),
                 ],
                 $attributes,
             );

tests/UserInterface/JobSecurityTest.php

@@ -41,7 +41,7 @@ public function __construct(private array $attributes)
 
             public function isGranted(mixed $attribute, mixed $subject = null): bool
             {
-                return in_array($attribute, $this->attributes, true)
+                return \in_array($attribute, $this->attributes, true)
                     && ($subject === null || $subject instanceof JobExecution);
             }
         };