Remove dependency to symfony/serializer for filesystem job execution storage

Author: yann-eugone

src/DependencyInjection/Configuration.php

@@ -39,7 +39,9 @@ private function storage(): ArrayNodeDefinition
                         ->scalarNode('dir')
                             ->defaultValue('%kernel.project_dir%/var/batch')
                         ->end()
-                        ->append($this->serializer())
+                        ->scalarNode('serializer')
+                            ->defaultValue('yokai_batch.job_execution_serializer.json')
+                        ->end()
                     ->end()
                 ->end()
                 ->arrayNode('dbal')
@@ -60,46 +62,4 @@ private function storage(): ArrayNodeDefinition
 
         return $node;
     }
-
-    private function serializer(): ArrayNodeDefinition
-    {
-        /** @var ArrayNodeDefinition $node */
-        $node = (new TreeBuilder('serializer'))->getRootNode();
-
-        $node
-            ->addDefaultsIfNotSet()
-            ->children()
-                ->scalarNode('format')
-                    ->defaultValue('json')
-                ->end()
-                ->scalarNode('service')
-                    ->defaultNull()
-                ->end()
-                ->arrayNode('symfony')
-                    ->addDefaultsIfNotSet()
-                    ->children()
-                        ->arrayNode('context')
-                            ->addDefaultsIfNotSet()
-                            ->children()
-                                ->arrayNode('common')
-                                    ->useAttributeAsKey('name')
-                                    ->variablePrototype()->end()
-                                ->end()
-                                ->arrayNode('serialize')
-                                    ->useAttributeAsKey('name')
-                                    ->variablePrototype()->end()
-                                ->end()
-                                ->arrayNode('deserialize')
-                                    ->useAttributeAsKey('name')
-                                    ->variablePrototype()->end()
-                                ->end()
-                            ->end()
-                        ->end()
-                    ->end()
-                ->end()
-            ->end()
-        ;
-
-        return $node;
-    }
 }

src/DependencyInjection/YokaiBatchExtension.php

@@ -16,7 +16,6 @@
 use Symfony\Component\Serializer\SerializerInterface;
 use Symfony\Component\Validator\Validator\ValidatorInterface;
 use Yokai\Batch\Bridge\Doctrine\DBAL\DoctrineDBALJobExecutionStorage;
-use Yokai\Batch\Bridge\Symfony\Serializer\SerializerJobExecutionSerializer;
 use Yokai\Batch\Launcher\JobLauncherInterface;
 use Yokai\Batch\Storage\FilesystemJobExecutionStorage;
 use Yokai\Batch\Storage\JobExecutionStorageInterface;
@@ -91,40 +90,12 @@ private function configureStorage(ContainerBuilder $container, array $config): v
 
             $defaultStorage = 'yokai_batch.storage.dbal';
         } elseif (isset($config['filesystem'])) {
-            $serializer = $config['filesystem']['serializer'];
-            $format = $serializer['format'];
-
-            if (isset($serializer['service'])) {
-                $serializerId = $serializer['service'];
-            } elseif (isset($serializer['symfony'])) {
-                if (!interface_exists(SerializerInterface::class)) {
-                    throw new \LogicException(); //todo
-                }
-
-                $serializerId = 'yokai_batch.job_execution_serializer.filesystem_storage';
-                $container
-                    ->register($serializerId, SerializerJobExecutionSerializer::class)
-                    ->setArguments(
-                        [
-                            new Reference(SerializerInterface::class),
-                            $format,
-                            $serializer['symfony']['context']['common'],
-                            $serializer['symfony']['context']['serialize'],
-                            $serializer['symfony']['context']['deserialize'],
-                        ]
-                    )
-                ;
-            } else {
-                throw new \LogicException(); //todo
-            }
-
             $container
                 ->register('yokai_batch.storage.filesystem', FilesystemJobExecutionStorage::class)
                 ->setArguments(
                     [
-                        new Reference($serializerId),
+                        new Reference($config['filesystem']['serializer']),
                         $config['filesystem']['dir'],
-                        $format,
                     ]
                 )
             ;

src/Resources/services/symfony/serializer/serializer.xml renamed to src/Resources/services/global/serializer.xml

@@ -7,9 +7,7 @@
     <services>
         <defaults public="false"/>
 
-        <service id="yokai_batch.job_execution_serializer.symfony_serializer.job_execution_normalizer"
-                 class="Yokai\Batch\Bridge\Symfony\Serializer\JobExecutionNormalizer">
-            <tag name="serializer.normalizer"/>
-        </service>
+        <service id="yokai_batch.job_execution_serializer.json"
+                 class="Yokai\Batch\Serializer\JsonJobExecutionSerializer"/>
     </services>
 </container>