Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move visualisation-related code to kobuki_desktop #315

Closed
bit-pirate opened this issue Dec 10, 2013 · 0 comments
Closed

Move visualisation-related code to kobuki_desktop #315

bit-pirate opened this issue Dec 10, 2013 · 0 comments
Labels
component:firmware type:enhancement
Milestone
Indigo

Comments

@bit-pirate
Copy link
Contributor

Daniel just noticed, we still have visualisation launchers for tests in kobuki_node (see PR #313). Those launchers however bring in the heavy rviz dependency. Move those launchers out into a separate package in the kobuki_desktop repo (just as we did for TB).

Don't forget to remove the rviz dependency for kobuki_node: https://github.com/yujinrobot/kobuki/blob/hydro/kobuki_node/package.xml#L77
@ghost ghost assigned bit-pirate Dec 10, 2013
@bit-pirate bit-pirate mentioned this issue Dec 10, 2013
Merged
bit-pirate added a commit that referenced this issue Dec 10, 2013
@bit-pirate
removes rviz launcher and dependency (fixes #315)
5d89293
@stonier stonier closed this as completed Dec 10, 2013
@jakan2 jakan2 assigned yhju and unassigned bit-pirate Mar 19, 2014
@jakan2 jakan2 assigned jakan2 and yhju and unassigned yhju and jakan2 Mar 19, 2014
@stonier stonier modified the milestones: Igloo, Indigo Dec 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:firmware type:enhancement
Projects
None yet
Milestone
Indigo
Development

No branches or pull requests
4 participants
@stonier @bit-pirate @yhju @jakan2