Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kobuki_node and kobuki_capabilities circular dependency #331

Closed
jihoonl opened this issue Jul 24, 2014 · 5 comments
Closed

kobuki_node and kobuki_capabilities circular dependency #331

jihoonl opened this issue Jul 24, 2014 · 5 comments
Assignees
Milestone

Comments

@jihoonl
Copy link
Collaborator

jihoonl commented Jul 24, 2014

#330 detected circular dependency between kobuki_node and kobuki_capabilities

@jihoonl jihoonl added this to the Indigo milestone Jul 24, 2014
@jihoonl
Copy link
Collaborator Author

jihoonl commented Jul 24, 2014

Both packages have launch file which reference each other.

  • app_manager_with_capabilities.launch in kobuki_node uses kobuki_capabilities package.
  • kobuki_bringup provider in kobuki_capabilities uses kobuki_node params and nodelet.

@jihoonl jihoonl mentioned this issue Aug 4, 2014
@bit-pirate bit-pirate self-assigned this Aug 7, 2014
@bit-pirate
Copy link
Contributor

Looks like we need to do sth with app_manager_with_capabilities.launch

Don't want to drop it, since the auto docking and random walker app runs with just Kobuki + rapp platform. So, I'll move that launcher to the capabilities package.

Any better idea?

@bit-pirate
Copy link
Contributor

This solution is now part of PR #334.

@bit-pirate bit-pirate mentioned this issue Aug 7, 2014
@jihoonl
Copy link
Collaborator Author

jihoonl commented Aug 8, 2014

f95c384 should have fixed the problem

@jihoonl jihoonl closed this as completed Aug 8, 2014
@bit-pirate
Copy link
Contributor

Aish, "solves" is not a valid keyword. "resolves" it should have been... :-)

https://help.github.com/articles/closing-issues-via-commit-messages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants