[joyop] update dynamic configuration #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stonier
reviewed
Oct 18, 2016
| @@ -246,6 +255,13 @@ void JoyOp::publish() | |||
| } | |||
| } | |||
|
|
|||
| void JoyOp::reconfigCB(gopher_core_msgs::BagJoystickConfig &config, uint32_t level) | |||
| { | |||
| ROS_INFO("Reconfigure joystick linear : %f, angular : %f", config.linear_scale, config.angular_scale); | |||
There was a problem hiding this comment.
Any ROS_INFO comments should follow the format used in the rest of this cpp code, i.e.
ROS_INFO("JoyOp: ...")
stonier
reviewed
Oct 18, 2016
| @@ -41,6 +44,9 @@ class JoyOp | |||
| bool enable_pressed_, disable_pressed_, deadman_pressed_, brake_pressed_, boost_active_, zero_twist_published_; | |||
| int wait_for_connection_; /**< Time to wait for enable/disable topics in seconds (-1 to not wait). **/ | |||
| ros::Timer timer_; | |||
|
|
|||
| dynamic_reconfigure::Server<gopher_core_msgs::BagJoystickConfig> * dynamic_reconfigure_server; | |||
| dynamic_reconfigure::Server<gopher_core_msgs::BagJoystickConfig>::CallbackType dynamic_reconfigure_callback; | |||
There was a problem hiding this comment.
Does this actually need to be a class variable? It never goes beyond the scope of the constructor.
|
Oh damn...I'm sorry. Open You'll have to move the dynamic reconfiguration file to yocs_msgs....that should have actually been obvious ;) |
stonier
reviewed
Oct 18, 2016
| @@ -11,6 +11,8 @@ | |||
| #include <std_msgs/String.h> | |||
| #include "boost/thread/mutex.hpp" | |||
| #include "boost/thread/thread.hpp" | |||
| #include <dynamic_reconfigure/server.h> | |||
| #include <gopher_core_msgs/BagJoystickConfig.h> | |||
There was a problem hiding this comment.
This should be called JoystickConfig, not BagJoystickConfig. The configuration actually has nothing to do with bagging at all. Bagging is just an example user.
|
@stonier I've fix them. |
|
Related PR: |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update joystick update dynamic configuration.