Remove all secrets on delete incl. pooler #1091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FxKu
requested review from
avaczi,
CyberDem0n,
erthalion,
Jan-M,
RafiaSabih and
sdudoladov
as code owners
FxKu
force-pushed
the
delete-pooler-secret
branch
from
9c6c823 to
521c27f
Compare
Jan-M
reviewed
Aug 10, 2020
| } else { | ||
| uid := secret.UID | ||
| if err = c.deleteSecret(uid, *secret); err != nil { | ||
| return fmt.Errorf("could not delete pooler secret: %v", err) |
There was a problem hiding this comment.
does this prevent deletion of e.g deployment? disable pooler should cleanup as good as it gets.
There was a problem hiding this comment.
nope. 1. Deployment, 2. Service, 3. Secret
It's true, however, that if 1. or 2. return an error the rest is not deleted.
|
👍 |
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets secrets on SYNC, so that they can be deleted.
On connection pooler deletion the corresponding secret is now removed via API call. Because of the way roles and secrets are synced with the
needCoonectionPoolercondition, the pooler user and secret are no longer set after deletion. But resources would still be there. For the database user it's fine - operator does not delete those in general - but the secret should go.