Add scheduler name support - [Update #990] #1226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbsbb
requested review from
avaczi,
CyberDem0n,
erthalion,
FxKu,
Jan-M,
RafiaSabih and
sdudoladov
as code owners
|
👍 |
FxKu
reviewed
Nov 23, 2020
|
should be documented here: https://github.com/zalando/postgres-operator/blob/master/docs/reference/cluster_manifest.md |
|
CRDs adjusted, documentation for the spec option added. |
FxKu
reviewed
Nov 24, 2020
|
can you rebase with the master. I've just merged a fix for CRDs and also updated go modules. Ideally, only changes relevant for this PR should be contained (e.g. no change to makefile etc.). |
On it. |
Cheers, let me know if anything else is necessary. |
FxKu
reviewed
Nov 25, 2020
|
Did one minor update as the scheduler name is only set for the database pods. Thanks @bbsbb for this contribution 😃 |
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
This is an updated, rebased continuation of Micah Coletti's PR allowing specification of an alternative scheduler.
If there is additional work that needs to be done on this to meet a standard deserving of merging, I'm up for it.
Would really appreciate involvement and direct answer if this is something that could become part of the postgres operator as it is a blocking issue for us.
Thank you for the great work on the project!