Added the ability to pass a alternative scheduler #990
Conversation
mcoletti
requested review from
CyberDem0n,
FxKu,
Jan-M,
RafiaSabih,
avaczi,
erthalion and
sdudoladov
as code owners
| (*in)[i].DeepCopyInto(&(*out)[i]) | ||
| } | ||
| } | ||
| if in.SchedulerName != nil { |
There was a problem hiding this comment.
Hi, I compiled your PR because I'm interested in using it because I have to use stork as well. When I did make docker I'm receiving these errors:
pkg/apis/acid.zalan.do/v1/zz_generated.deepcopy.go:649:22: invalid operation: in.SchedulerName != nil (mismatched types string and nil)
pkg/apis/acid.zalan.do/v1/zz_generated.deepcopy.go:651:8: cannot use new(string) (type *string) as type string in assignment
pkg/apis/acid.zalan.do/v1/zz_generated.deepcopy.go:652:3: invalid indirect of *out (type string)
pkg/apis/acid.zalan.do/v1/zz_generated.deepcopy.go:652:11: invalid indirect of *in (type string)
well, that's the reason Travis failed aswell
There was a problem hiding this comment.
run ./hack/update-codegen.sh and maybe make deps in case you get compiler errors
|
What is the status on this? Is there intent to get it merged or is there a block I can help with solving around it? |
5 participants
This PR will enable using the CRD to pass in the schedulerName to be used. We use Portworx which leverages the stork scheduler.