quickstart: add scheme to URL if not present #4373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingthorin
approved these changes
Jan 24, 2023
psiinon
reviewed
Jan 24, 2023
| @@ -70,6 +70,7 @@ quickstart.launch.start.option.label = Start Page: | |||
| quickstart.launch.start.pulldown.url = URL (specify below) | |||
| quickstart.launch.start.pulldown.zap = Default ZAP Page | |||
| quickstart.launch.start.pulldown.blank = Blank Page | |||
| quickstart.launch.start.url.access.error = Failed to access: {0}\nTry specify the URL directly in the browser. | |||
There was a problem hiding this comment.
Also, which browser is the user supposed to try? One launched from ZAP or any? I can see people being confused by this. Maybe something like "Try specifying the URL directly in a browser to check it is accessible"?
There was a problem hiding this comment.
I thought it would be clear, ZAP just launched the browser. Would this be better "Failed to automatically open the URL in the launched browser:\n{0}\nTry specifying the URL directly." ?
There was a problem hiding this comment.
Ah - my bad, I was thinking this was when running the automated scan 😉
I'm good with "Try specifying the URL directly in the browser." then
Add a scheme to the URL if not already present, also, access the URL separately to provide an appropriate error message (i.e. failed to access the URL rather than launch the browser). Signed-off-by: thc202 <thc202@gmail.com>
thc202
force-pushed
the
quickstart/scheme-add
branch
from
ab77e90
to
6cac219
Compare
kingthorin
approved these changes
Jan 24, 2023
psiinon
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a scheme to the URL if not already present, also, access the URL separately to provide an appropriate error message (i.e. failed to access the URL rather than launch the browser).