Skip to content

v0.9.5

Choose a tag to compare

@zcalusic zcalusic released this 29 Oct 22:51
· 34 commits to master since this release
v0.9.5

Seeds that resolve later or move, two memory fixes found by AddressSanitizer, and more build and test coverage in CI.

Upgrade notes

  • A seed in dyn_seeds whose name doesn't resolve no longer makes the configuration invalid: the node starts with a warning and that peer counts as down until its name resolves. A typo in a seed name now shows up as a down peer and repeated "address resolution ... failed" log lines, not as a refused start.
  • A peer's name is looked up again before every connection attempt, so a node follows a peer whose name moves to another address (logged as "peer '...' resolves to ... now"). The lookup blocks the node while it runs: with a slow or unreachable DNS server, a node can stall for up to the resolver's timeout, once per reconnect backoff. Seeds given as IP addresses aren't affected.
  • A node now starts even when connecting to one of its peers fails at once; before, that stopped the node, and peers listed after the failing one weren't connected at startup.

Fixes

  • Read repair: when the stale reply came from the local datastore, the repair wrote a byte past the end of a heap block. And a stale reply from a peer listening on different ports than the coordinator marked that peer as local for good, so requests meant for it went to the local datastore.
  • Command names in the Redis and memcache parsers, the MD5 and Hsieh hashes and an internal hash table read 2- and 4-byte words at unaligned addresses, which is undefined behaviour and can fault on CPUs other than x86. They are loaded safely now, with the same results and speed on x86.
  • The hash_tag configuration string was never freed.
  • A gossip peer update with no nodes returned an uninitialized status.

Testing

  • CI also builds with clang and for 32-bit x86 (with -Werror, running the unit tests), and runs the unit and functional tests under AddressSanitizer and UndefinedBehaviorSanitizer, which found the two memory fixes above.
  • A new functional test, test/seed_test.py, starts a node with a seed whose name doesn't resolve yet, then makes it resolve and moves it to another address.

Full Changelog: v0.9.4...v0.9.5