Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown Tables are Misaligned in Preview #11024

Closed
1 task done
Tracked by #5346
someone13574 opened this issue Apr 26, 2024 · 1 comment · Fixed by #18315
Closed
1 task done
Tracked by #5346

Markdown Tables are Misaligned in Preview #11024

someone13574 opened this issue Apr 26, 2024 · 1 comment · Fixed by #18315
Labels
bug [core label] language An umbrella label for all programming languages syntax behaviors markdown renderer markdown Markdown markup support

Comments

@someone13574
Copy link
Contributor

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

The preview of complex tables in markdown tables do not align columns properly, meaning that it is hard to follow what they actually display. This seems to be caused by tables with content of differing lengths while in a table with multiple columns and rows.

Text table:

| Bit(s) | Stage | Name                       | Description                                                                                                                    |
| ------ | ----- | ---------------------------|--------------------------------------------------------------------------------------------------------------------------------|
| 0      | s0    | `check_rs1_dep`            | Enables data dependency check for rs1.                                                                                         |
| 1      | s0    | `check_rs2_dep`            | Enables data dependnecy check for rs2.                                                                                         |
| 2-3    | s0    | `pre_alu_a_select`         | Used to multiplex alu input a's input ahead of time.                                                                           |
| 4-6    | s0    | `pre_alu_b_select`         | Used to multiplex alu input b's input ahead of time.                                                                           |
| 7-9    | s0    | `cmp_op_select`            | Selects a comparison operation for branching.                                                                                  |
| 10     | s1    | `mem_in_use`               | Signals that memory is used by this operation, thus stalling the pipeline.                                                     |
| 11-14  | s1    | `alu_op_select`            | Selects an ALU operation.                                                                                                      |
| 15     | s2    | `mem_write_enable`         | Enables the write signal for memory.                                                                                           |
| 16     | s2    | `alu_out_to_mem_addr`      | Toggles between connecting the alu output or the program counter to the memory address.                                        |
| 17     | s2    | `jump_if_branch`           | Executes a jump if the branch condition is true.                                                                               |
| 18-19  | s2    | `pre_writeback_select`     | Used to multiplex the memory input ahead of time.                                                                              |
| 20     | s3    | `reg_write_enable`         | Enables the write signal for the registers.                                                                                    |
| 21     | s3    | `use_pre_wb_over_mem_data` | Toggles between using the multiplexed `pre_writeback` and using the output memory data as an input to the register input data. |

Small window screenshot:
Screenshot from 2024-04-25 21-50-07

Large window screenshot:
Screenshot from 2024-04-25 21-50-54

Environment

Zed: v1.0.0 (Zed Dev ab6b7ba)
OS: Linux 1.0.0
Memory: 31.3 GiB
Architecture: x86_64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response

@someone13574 someone13574 added admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue labels Apr 26, 2024
@JosephTLyons JosephTLyons added markdown Markdown markup support language An umbrella label for all programming languages syntax behaviors and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Apr 26, 2024
@JosephTLyons
Copy link
Collaborator

cc @bennetbo

noaccOS pushed a commit to noaccOS/zed that referenced this issue Oct 19, 2024
- Closes: zed-industries#11024

## Release Notes:

- Improved Markdown Preview rendering of tables

## Before:


![image](https://github.com/user-attachments/assets/25f05604-38a9-4bde-901c-6d53a5d9d94d)

<img width="2035" alt="Screenshot 2024-09-25 at 05 47 19"
src="https://github.com/user-attachments/assets/a30c56f5-4793-44c2-8527-294189f9e724">

## Now:


![image](https://github.com/user-attachments/assets/ce06f045-d0db-4b8c-a1fc-2811d35f2683)


<img width="2040" alt="Screenshot 2024-09-25 at 05 47 48"
src="https://github.com/user-attachments/assets/76e5d217-9110-4c5d-9fad-dc63ae0b75f4">

## Note:

I'm not a Rust programmer and this is my first PR in Zed (because i just
want to fix this, so i can view my notes in Markdown in Zed, not slow
Visual Studio Code) - so there may be errors. I'm open for critic a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug [core label] language An umbrella label for all programming languages syntax behaviors markdown renderer markdown Markdown markup support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants