-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown preview image rendering #21082
Conversation
Co-authored-by: Mikayla Maki <mikayla.c.maki@gmail.com>
Co-authored-by: Mikayla Maki <mikayla.c.maki@gmail.com>
This is awesome! Just tried it out in the 0.164.2 stable release. The only issue I can see is that the images don't scale. For example, I have a really wide image that I can only see half of in the preview. Resizing the window makes it worse as text wraps correctly, but the image just gets cropped. |
Happy to see this land — are the supported image types documented anywhere? I use JPEG-XL when authoring Markdown, which is otherwise supported by macOS, Safari, etc. — would be super neat if it ended up being supported in Zed too! |
Seeing as it uses zed/crates/gpui/src/elements/img.rs Lines 201 to 210 in 6ebd6c2
|
And going off of the comment in that snippet referring to |
…ion (#21630) Follow up to #21082 Similar to checkboxes, you can now click on the image to navigate to the source location, cmd-clicking opens the url in the browser. https://github.com/user-attachments/assets/edaaa580-9d8f-490b-a4b3-d6ffb21f197c Release Notes: - N/A
Closes #13246
Supersedes: #16192
I couldn't push to the git fork this user was using, so here's the exact same PR but with some style nits implemented.
Release Notes: