Clean up naming conventions project-wide #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
* BufferElement -> EditorElement Co-Authored-By: Nathan Sobo <nathan@zed.dev>
maxbrunsfeld
force-pushed
the
naming-cleanup
branch
from
f4bfc12
to
6ef4478
Compare
SomeoneToIgnore
added a commit
that referenced
this pull request
Jul 14, 2023
Closes https://github.com/zed-industries/community/issues/75 Closes https://github.com/zed-industries/community/issues/1749 The PR * changes keybindings for `Editor && mode == auto_height` context: before, `alt-enter` and `alt-shift-enter` added new lines in such editors, including the one from buffer search. New bindings are the same as in `Editor && mode == full` context. * adds `search::SelectAllMatches` action and binds it to `Alt + Enter` by default, to select all matches of a buffer search The behavior mimics VSCode: we do not move the screen even if all selections are out of the visible range (Cmd+G will navigate there) and allow reselecting the results from both pane and search field, as long as the search is not dismissed. Release Notes: - Added `search::SelectAllMatches` (`Alt + Enter` default) action to place carets and select all buffer search results ([#75](https://github.com/zed-industries/community/issues/75), [#1749](https://github.com/zed-industries/community/issues/1749)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #49
Closes #72
This PR makes three naming changes:
buffermodule), move the module's root file outside of the module directory, and rename it to match the module. For example, this renamesbuffer/mod.rstobuffer.rs. This makes the file easier fine using the fuzzy finder.BufferViewmodule - This renamesBufferView->Editor. Previously, that type was our only view whose name ended withView. The wordEditoris also just nicer to say and to type.AppContext,MutableAppContext, andModelContext<T>) were named a mixture ofappandctx. This renames them all tocx.