Skip to content
This repository was archived by the owner on May 1, 2019. It is now read-only.

Conversation

ins0
Copy link
Contributor

@ins0 ins0 commented Oct 20, 2015

This PR

  • jumps to the latest stable dependencies versions
    • ZF2 v2.5
    • scn-social-auth v1.18.1
    • htmlpurifier v4.7.0
    • zfc-user v1.3.3
  • fixes followed errors due to major dependencies upgrades
  • adds UserController test case
  • replace the composer meta package zendframework/zendframework with the separated zend packages (generally replace - nothing sorted out)
  • increased required php version to ``5.6`
  • adds the Roave SecurityAdvisories package
  • update the composer.lock file

fixes #507

/cc @Ocramius @localheinz

composer.json Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a workaround as long as EvanDotPro/EdpGithub#42 isn't merged, as composer wouldn't update our dependencies without.

should stay or should we wait?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ins0 why doesn't a stable version work? I don't see any particular differences

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because the stable version required zend 2.2 but the pr is merged so i can update this

@ins0
Copy link
Contributor Author

ins0 commented Oct 20, 2015

no clue why scrutinizer hates me today :rage2:

@ins0
Copy link
Contributor Author

ins0 commented Oct 21, 2015

@localheinz or @Ocramius could you please have a look 😃

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a test case

@gianarb
Copy link
Contributor

gianarb commented Oct 24, 2015

@ins0 edpgithub 0.4.0 is ready :)

@ins0
Copy link
Contributor Author

ins0 commented Oct 24, 2015

thanks for the info @gianarb i will update this 👍

@Ocramius
Copy link
Member

@ins0 any changes needed? I assume we don't need to alias the requirements anymore..

@ins0
Copy link
Contributor Author

ins0 commented Oct 25, 2015

@Ocramius unfortunately the packagist repo isn't updated, so @gianarb could you do this too or did we need to ask @EvanDotPro to do this please?

@Ocramius
Copy link
Member

It's up to @Hounddog

@ins0
Copy link
Contributor Author

ins0 commented Oct 26, 2015

thanks @Hounddog

ping @Ocramius
don't know why travis not showing a green build, but its run green like the latest runs too. 🎱

@Ocramius
Copy link
Member

@ins0 had this issue with travis also with other builds, I think it's not on our side atm.

Ocramius added a commit that referenced this pull request Oct 27, 2015
Enhancement/Update Composer Dependencies
@Ocramius Ocramius merged commit 0f6d20c into zendframework:master Oct 27, 2015
@Ocramius
Copy link
Member

Thanks for your effort on this, @ins0!

@ins0
Copy link
Contributor Author

ins0 commented Oct 27, 2015

thanks @Ocramius

@ins0 ins0 deleted the fix/security branch October 27, 2015 07:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Security vulnerability detected

3 participants