Remove size assert #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This assert does seem valid, however there may be GLTF models where each of the primitives buffer view contains a view to all primitives. One such example is Sponza from glTF-Sample-Assets.
hazeycode
approved these changes
Feb 16, 2025
There was a problem hiding this comment.
Yes, this is too strict. Thanks!
I think we should delete the preceding assert also. Asserts aren't a good fit here because we're dealing with external data. Better to use errors for any show stopping problems with the input. And any nice to have checks should be moved to auxiliary validation functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The assertion that the buffer view should strictly contains a view to the primitive it belongs to is sane , however I found that the GLTF Sponza model from the glTF-Sample-Assets has each of the primitives buffer view containing data for all primitives, not only the subset. In other words, the buffer view is identical for each
glTF primitive indexwhich views all data.With the assertion, the library fails to load this model. Removing the assert, I can load each submesh with no issues.
Strictly speaking, in this case we found that the
accessor size <= buffer view sizeand notaccessor size == buffer view size.Therefore, I believe this assertion is too strict and should be removed.