Fixes for zero-sized allocation #1045
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaachier
commented
Jun 3, 2018
| } | ||
|
|
||
| assert(!struct_type->data.structure.zero_bits_loop_flag); | ||
| assert(struct_type->data.structure.fields); |
| assert(decl_node->type == NodeTypeContainerDecl); | ||
|
|
||
| size_t field_count = struct_type->data.structure.src_field_count; | ||
| assert(struct_type->data.structure.fields != nullptr || field_count == 0); |
| struct_type->di_type = replacement_di_type; | ||
| return; | ||
| } | ||
| assert(struct_type->di_type); |
| return; | ||
| } | ||
| assert(struct_type->di_type); | ||
| assert(struct_type->di_type != nullptr || field_count == 0); |
| // if you hit this assert then probably this type or a related type didn't | ||
| // get ensure_complete_type called on it before using it with something that | ||
| // requires a complete type | ||
| assert(LLVMStoreSizeOfType(g->target_data_ref, struct_type->type_ref) > 0); |
| // get ensure_complete_type called on it before using it with something that | ||
| // requires a complete type | ||
| assert(LLVMStoreSizeOfType(g->target_data_ref, struct_type->type_ref) > 0); | ||
| assert(LLVMStoreSizeOfType(g->target_data_ref, struct_type->type_ref) > 0 || |
| 128, | ||
| }; | ||
|
|
||
| struct CIntTypeInfo { |
There was a problem hiding this comment.
Padding fix discussed in #993.
|
|
||
| template<typename T> | ||
| ATTRIBUTE_RETURNS_NOALIAS static inline T *allocate(size_t count) { | ||
| if (count == 0) { |
There was a problem hiding this comment.
Makes behavior for zero sized allocation portable.
| T *ptr = reinterpret_cast<T*>(realloc(old, new_count * sizeof(T))); | ||
| if (!ptr) | ||
| zig_panic("allocation failed"); | ||
| static inline T *reallocate(T *old, size_t old_count, size_t new_count) { |
There was a problem hiding this comment.
Implement reallocate using reallocate_nonzero to avoid code duplication.
| errors[error_entry->value] = error_entry; | ||
| } | ||
| ZigList<ErrorTableEntry *> intersection_list = {}; | ||
| ZigList<ErrorTableEntry *> intersection_list = {0}; |
There was a problem hiding this comment.
You will see this in a few places. ZigList needs to be initialized in order to guarantee the members are zeroed.
There was a problem hiding this comment.
Can you cite a source showing that {0} is necessary and {} is not sufficient?
There was a problem hiding this comment.
Actually you are right: https://stackoverflow.com/a/1069634/1930331. Maybe I'm thinking about C, but C++ will work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1044.