Scan from line start when finding tag in tokenizer #12692
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moosichu
force-pushed
the
fix/carriage-return-crash-2
branch
2 times, most recently
from
fd9c2bf
to
f92a68e
Compare
|
|
moosichu
force-pushed
the
fix/carriage-return-crash-2
branch
from
f92a68e
to
c02a211
Compare
|
Only just found some time to get around to this! Good shout, that change has been pushed. |
moosichu
force-pushed
the
fix/carriage-return-crash-2
branch
from
c02a211
to
533901a
Compare
moosichu
force-pushed
the
fix/carriage-return-crash-2
branch
from
533901a
to
6bea9c4
Compare
This resolves a crash that can occur for invalid bytes like carriage returns that are valid characters when not parsed from within literals. There are potentially other edge cases this could resolve as well, as the calling code for this function didn't account for any potential 'pending_invalid_tokens' that could be queued up by the tokenizer from within another state.
moosichu
force-pushed
the
fix/carriage-return-crash-2
branch
from
6bea9c4
to
06b994d
Compare
andrewrk
requested changes
Oct 30, 2022
|
#12661 Already supercedes this anyway, so if you are happy with that (especially because it has tests) I don't think this needs to be merged. This was mainly intended as a quick low-risk workaround for a known crash, whereas #12661 actually fixes the issue by adhering to the spec. Will close this for now! Mainly becuase any tests for this would be made redundant very quickly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves a crash that can occur for invalid bytes like carriage
returns that are valid characters when not parsed from within literals.
There are potentially other edge cases this could resolve as well, as
the calling code for this function didn't account for any potential
'pending_invalid_tokens' that could be queued up by the tokenizer from
within another state.
This PR resolves #12674 and will unblock #12661.
#12449 could later simplify this when implemented, however this was a super simple change and fixes a known crash.