Skip to content

cbe: revert movement of zig_float_from_repr to before float typedefs #14189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 4, 2023

Conversation

kcbanner
Copy link
Contributor

@kcbanner kcbanner commented Jan 4, 2023

The calls to zig_float_from_repr need to come after the float typedefs, otherwise it's a compile error:

zig\lib\zig.h(1780): error C2061: syntax error: identifier 'zig_float_from_repr_f16'
zig\lib\zig.h(1780): error C2059: syntax error: ';'
zig\lib\zig.h(1780): error C2059: syntax error: '<parameter-list>'
zig\lib\zig.h(1781): error C2061: syntax error: identifier 'zig_float_from_repr_f32'
zig\lib\zig.h(1781): error C2059: syntax error: ';'
zig\lib\zig.h(1781): error C2059: syntax error: '<parameter-list>'
zig\lib\zig.h(1782): error C2061: syntax error: identifier 'zig_float_from_repr_f64'
zig\lib\zig.h(1782): error C2059: syntax error: ';'
zig\lib\zig.h(1782): error C2059: syntax error: '<parameter-list>'
zig\lib\zig.h(1783): error C2061: syntax error: identifier 'zig_float_from_repr_f80'
zig\lib\zig.h(1783): error C2059: syntax error: ';'
zig\lib\zig.h(1783): error C2059: syntax error: '<parameter-list>'
zig\lib\zig.h(1784): error C2061: syntax error: identifier 'zig_float_from_repr_f128'
zig\lib\zig.h(1784): error C2059: syntax error: ';'
zig\lib\zig.h(1784): error C2059: syntax error: '<parameter-list>'
zig\lib\zig.h(1785): error C2061: syntax error: identifier 'zig_float_from_repr_c_longdouble'
zig\lib\zig.h(1785): error C2059: syntax error: ';'
zig\lib\zig.h(1785): error C2059: syntax error: '<parameter-list>'

This reverts part of the change in 5bd69c6

@kcbanner kcbanner force-pushed the cbe_fix_float_from_repr branch from f32955d to 6d0c921 Compare January 4, 2023 06:26
@andrewrk andrewrk merged commit 9ed4a93 into ziglang:master Jan 4, 2023
@kcbanner kcbanner deleted the cbe_fix_float_from_repr branch January 8, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants