-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IKEA Styrbar remote quirk #867
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #867 +/- ##
==========================================
+ Coverage 82.50% 82.59% +0.09%
==========================================
Files 185 190 +5
Lines 4589 4810 +221
==========================================
+ Hits 3786 3973 +187
- Misses 803 837 +34
Continue to review full report at Codecov.
|
Pull Request Test Coverage Report for Build 1075781775
💛 - Coveralls |
Is this still a draft? |
I have one in production and one in test system and the ground looks working OK for my = binding and reporting of light groups (great work @TheJulianJES !!). Its spamming the network badly then setting up binding and reporting and perhaps need more default response for not doing that. If binding one cluster = one unicast command sent. I think its more or less the same with Symphoisk sound controller and short cut button (newer SDK used then the "old" remotes). I think the best was that you was having one for testing how its reacting for understanding the "personality" but if you like i can do all sniffing and config you need only saying wot you like to having. |
The commands for the next and privies scene is not working then they have changing the commands being sent and need being adopted for the automation part. |
It's still unfinished. The left/right buttons aren't working apparently and I don't have one of these remotes (or time atm). It can be directly bound to a device/group and I think the left/right arrow buttons might work when the "Zigbee scenes" are added to the device(?) (because only with the last commit the scenes cluster can be bound. Still not sure how much this helps) I guess I could remove the device automation triggers for left/right arrow buttons, so users don't get confused why this functionality isn't working. Perhaps it could be merged to have a "basic implementation" for the device then. Left/right arrow buttons (and network spam) can be addressed later. |
The scenes buttons are working out of the box with CWS3 (they have different implanting of the default scenes) and very likely also if adding scenes to the "magic group" for older IKEA WS/CWS lights. I have not testing binding the scene cluster to one group then i cant adding scenes in ZHA. |
By adding scene cluster (from IKEA quirk) like this in the replacement:
I starting getting real commands from the scenes buttons !!!
The IKEA scene is decoding the release OK as command 9 but with random parameters so not possible saying if right or left was released:
Its possible implanting logic for release right or left if ignoring the value 0x0000 that is sent for resetting the lights to default sens and light levels as is being done in the open/close button by remember that last long press command. @TheJulianJES Is it one typo |
@Adminiuga I need help with the spamming from this remote ;-((
The hole sequenze looks like this for eatch command recived:
So all transactions is with the same tsn !! Is the tuya version possible implanting and is the right way to going ? zha-device-handlers/zhaquirks/tuya/__init__.py Lines 687 to 706 in b7e6173
Sorry for making more problems for you but its out of my (not very large) code knowledge but i think its many user that like getting this device being real supported (its working without quirk but not good and no device triggered ). PS: i have not checking if the device is getting default response from the coordinator then my sniffer is running EZSP six ten for the moment. |
One new version if the quirk is posted here #863 (comment). |
Make sure a default response is sent, which should be handled by zigpy, unless overriden by quirk |
OK i downgrading one Billy for doing sniff with 15.4 support so being sure but its normal ZCL commands so shall being done buy the stack if not being disabled (that we dont have). |
I was wrong the remote was bonded to one group and was spamming the group like this:
Then was resetting it and rejoining it was not spamming the group instead the coordinator that is not replaying with default response:
And the first frame revived of the coordinator looks like this:
The remote is sending sequences 21, 22, 23, 24 and 25 before its parent have relayed the first unicast to the coordinator and its not reseeding the commands then its dot have getting any default response (that is have demanding to getting but is not missing) anf if it have re sending the commands it shall have being with the same sequence numbers (21-25) so its no prblem with that. I was taking one look in SS5 and the parent is acking all commands from the remote in the IEEE 802.15.4 layer very nicely = OK. So if we is forcing ZHA sending default response its not helping the unicast. And all commands is with the same sequence number (tsn in ZHA) so still getting the spamming until IKEA is fixing the firmware. The Shortcut button and Symphonisk is having more or less the same "spamming" and if implanting tsn check its also being good doing it in there quirks 2 (and perhaps the old dimmer switch that is not working so well) but that is one later problem. More thinking ? Thanks in advance. MW |
@Adminiuga It looks like our TheJulianJES is on Holiday and more users is asking for support of this remote. I have getting all device automation working and its also working OK bounded to one light group so its have the same status as the Shortcut button that is also spamming the network. Shall i making one new PR for getting it true or can you patching this so its working OK or do you like waiting for TheJulianJES coming back ?? Mvh MW Edit: Adding my quirk that is being used for some weeks: |
@MattWestb Thanks for your work! Atm, I'm still kind of here. These quirks seem to be pretty identical now. I noticed that I had the scenes cluster in the I still don't have a device to test with though. If you have some time, you can check if this works the same as your version now. (As they're a basically identical now, I'd assume so.) To clarify, the device automations all work now, right? (Even the left/right buttons?) |
Welcome back from your holiday i the other space ;-) I downloading the quirk and installing it in my test setup and reporting back if i not must cutting away more of the sun-seal from the balcony then its full storm and 30° C with open sky here. Do you knowing of the new manufacture cluster ID ? i was naming it 3 for the 3rd gen controllers so not mixing it up with the old / normal one if we start using it in the future for setting up "relative" scenes. I´l bee back !! |
0xFC57/64599 is the "Work With All Hubs" cluster IIRC. |
Little events after much deleting spam:
Shall being the same commands sequence that i have sniffed in #863 (comment) but i have not trying triggering device automatons on them. For my its looks OK until we is getting little antispamm implanted for IKEA devices. Great thanks for implanting the quirk Julian !!! |
This PR is ready to review/merge now. Like the IKEA shortcut button, the remote seems to generate multiple The "spamming" issue needs to be looked at later (for all newer IKEA remotes), but this isn't caused by the quirk. |
@Adminiuga Do you have one MG21 board for your WSTK ? Interested ? |
I think (without knowing as usual) that IT is doing the right thing, if one command is being revived with the same tsn (from the same device with same EP and cluster) with broad an / or unicast in one short time frame its shall being treated as one command and the rest commands shall filtered out and "spam" in the lowest possible layer in the system. I think that shall being implanted in the radio libs or in zigpy layer for reusing the not needed commands sent between the layers in the system. The funny thing if cooking one "LO controller bridge" in SS5 and doing multiple binding of one cluster the stack is sending * cluster bindings of the command to the destination also then doing group binding plus unicats bindings so its in the ground one Silabs Zigbee stack personality. |
Hello, i would to know what i need to do because i m lost in the different information. How to use or install the quirk? Home Assistant deConz |
Is you using ZHA or deCONZ integration in HA ? |
I use deConz 6.10.0 in HA |
Then you need positing the ticket in https://github.com/dresden-elektronik/deconz-rest-plugin then this quirk is only working in ZHA and if you is using your deCONZ radio adapter with ZHA and not deCONZ integration. |
Fixes #863, fixes #975
Adds device automation triggers and doubles the power percentage.
Left/right click are apparently working now.
Like the IKEA shortcut button, this remote seems to generate multiple
zha_event
s.(At least for @MattWestb on a Silabs(?) coordinator. AFAIK, some people with a TI coordinator didn't have an issue with multiple events on the shortcut button.)
The "spamming" issue needs to be looked at later (for all newer IKEA remotes), but this isn't caused by the quirk.
(Reference: #967)
For now, this PR is ready for review.
More information:
#863 (comment)