Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Theme] disable asset combination #4419

Closed
craigh opened this issue Jul 23, 2020 · 4 comments
Closed

[Theme] disable asset combination #4419

craigh opened this issue Jul 23, 2020 · 4 comments
Labels
Bug
Milestone
3.1.0

Comments

@craigh
Copy link
Member

craigh commented Jul 23, 2020

I think we should consider shipping with
zikula_asset_manager.combine: false

I am consistently running into issues where I need to disable it in order for things to work as expected. Especially when developing - including installing/uninstalling extensions. It seems like a standard site-admin would experience these same issues.

We could then document converting to true as a performance improvement that should be done only after the site is "done" (e.g. all modules and themes decided and installed, etc)

not sure if this could/should be done on 3.0.1 or 3.1.0 since it is technically a significant change...
@craigh craigh added the Bug label Jul 23, 2020
@Guite
Copy link
Member

Guite commented Jul 23, 2020

💯

@craigh
Copy link
Member Author

craigh commented Jul 23, 2020

which milestone?

@Guite
Copy link
Member

Guite commented Jul 23, 2020

I am fine with 3.1.0.

@craigh craigh added this to the 3.1.0 milestone Jul 23, 2020
@craigh craigh changed the title disable asset combination [Theme] disable asset combination Jul 23, 2020
@craigh
Copy link
Member Author

craigh commented Sep 5, 2020

this was completed in #4433
more specifically here

@craigh craigh closed this as completed in bc65472 Sep 5, 2020
Guite added a commit that referenced this issue Sep 6, 2020
@Guite
updated changelog refs #4419
23593d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
3.1.0
Development

No branches or pull requests
2 participants
@Guite @craigh