#656 Add maketime function to MysqlSqlModule #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jczuchnowski
previously approved these changes
May 26, 2022
| @@ -34,6 +33,7 @@ trait MysqlSqlModule extends Sql { self => | |||
| val Log2 = FunctionDef[Double, Double](FunctionName("log2")) | |||
| val Log10 = FunctionDef[Double, Double](FunctionName("log10")) | |||
| val Pi = Expr.FunctionCall0[Double](FunctionDef[Any, Double](FunctionName("pi"))) | |||
| val MakeTime = FunctionDef[(Int, Int, Double), LocalTime](FunctionName("maketime")) | |||
There was a problem hiding this comment.
Please put it in an alphabetical order.
|
@sarahotoole accepted prematurely :). One small modification needed. |
jczuchnowski
approved these changes
May 26, 2022
|
Thank you and congrats on the first contribution! |
vidyasankarv
added a commit
to vidyasankarv/zio-sql
that referenced
this pull request
May 26, 2022
vidyasankarv
added a commit
to vidyasankarv/zio-sql
that referenced
this pull request
May 26, 2022
vidyasankarv
added a commit
to vidyasankarv/zio-sql
that referenced
this pull request
May 26, 2022
sviezypan
added a commit
to vidyasankarv/zio-sql
that referenced
this pull request
May 26, 2022
sviezypan
added a commit
that referenced
this pull request
May 26, 2022
#675 - Add uuid() function to MySqlModule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#656