Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#675 - Add uuid() function to MySqlModule #688

Merged
merged 2 commits into from
May 26, 2022
Merged

Conversation

vidyasankarv
Copy link
Contributor

No description provided.

@vidyasankarv vidyasankarv requested a review from a team as a code owner May 26, 2022 17:19
@CLAassistant
Copy link

CLAassistant commented May 26, 2022

CLA assistant check
All committers have signed the CLA.

val Pi = Expr.FunctionCall0[Double](FunctionDef[Any, Double](FunctionName("pi")))
val RPad = FunctionDef[(String, Int, String), String](FunctionName("rpad"))
val Pi = Expr.FunctionCall0[Double](FunctionDef[Any, Double](FunctionName("pi")))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this switch of Pi was not necessary :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok I see now its aranged in alphabetical order. I was trying group all FunctionCall together. will undo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed now

@sviezypan sviezypan merged commit 9b6b455 into zio:master May 26, 2022
@sviezypan
Copy link
Collaborator

Thank you for your work on this @vidyasankarv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants