Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added initial config for Frontend::Navigation###AdminCustomerUserCustomer###001-Framework #146

Merged
merged 3 commits into from
Oct 1, 2021

Conversation

BuTzZ
Copy link

@BuTzZ BuTzZ commented Sep 25, 2021

There was no initial config for this module. I tried to set it by using the web frontend, but then Prio didn't work for me (had no effect), maybe special case in my system.

But I think it would be fine if there is an inital config for it.

Proposed change

Just added initial config for Frontend::Navigation###AdminCustomerUserCustomer###1-Framework

1 - 💎 code quality

Breaking change

Additional information

Checklist

  • The code change is tested and works locally.(❗)
  • There is no commented out code in this PR.(❕)
  • You improved or added new unit tests.(❕)
  • Local ZnunyCodePolicy run passes successfully.(❕)
  • Local unit tests pass.(❕)
  • GitHub workflow ZnunyCodePolicy passes.(❗)
  • GitHub workflow unit tests pass.(❗)

There was no initial config for this module. I tried to set it by using the web frontend, but then Prio didn't work for me (had no effect), maybe special case in my system.
@dennykorsukewitz
Copy link
Member

before

Admin_-_znuny_dev_🔊

after

Admin_-_znuny_dev

@dennykorsukewitz dennykorsukewitz self-assigned this Sep 28, 2021
@dennykorsukewitz dennykorsukewitz added 1 - 🚀 feature New feature or request 2 - Frontend 2 - System/SysConfig 4 - verified This issue or pull request was verified. 3 - wait for reviewer Znuny, it's your turn. labels Sep 28, 2021
@dennykorsukewitz dennykorsukewitz added this to the rel-6_3_1 milestone Sep 28, 2021
Copy link
Member

@dennykorsukewitz dennykorsukewitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @BuTzZ,

i created a suggestion for you. ChangedPrio to 9101.

If you want, you can also activate this Navigation by default. Valid="1"

    <Setting Name="Frontend::Navigation###AdminCustomerUserCustomer###001-Framework" Required="0" Valid="1">

keep up the good work 😃 🚀 👍🏼

Kernel/Config/Files/XML/Framework.xml Outdated Show resolved Hide resolved
@dennykorsukewitz dennykorsukewitz added 3 - wait for contributor Contributor, it's your turn. and removed 3 - wait for reviewer Znuny, it's your turn. labels Sep 28, 2021
BuTzZ and others added 2 commits September 29, 2021 09:00
Changed Prio to 9101

Co-authored-by: Denny Korsukéwitz <dennykorsukewitz@gmail.com>
AdminCustomerUserCustomer is now enabled by default
@dennykorsukewitz dennykorsukewitz added 3 - wait for merge Znuny, it's your turn. and removed 3 - wait for contributor Contributor, it's your turn. labels Sep 29, 2021
@dennykorsukewitz dennykorsukewitz modified the milestones: rel-6_3_1, rel-6_2_1 Oct 1, 2021
@dennykorsukewitz dennykorsukewitz merged commit 2e383a9 into znuny:dev Oct 1, 2021
@dennykorsukewitz dennykorsukewitz removed the 3 - wait for merge Znuny, it's your turn. label Oct 1, 2021
dennykorsukewitz added a commit that referenced this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - 🚀 feature New feature or request 2 - Frontend 4 - verified This issue or pull request was verified.
Development

Successfully merging this pull request may close these issues.

2 participants