-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added initial config for Frontend::Navigation###AdminCustomerUserCustomer###001-Framework #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was no initial config for this module. I tried to set it by using the web frontend, but then Prio didn't work for me (had no effect), maybe special case in my system.
dennykorsukewitz
added
1 - 🚀 feature
New feature or request
2 - Frontend
2 - System/SysConfig
4 - verified
This issue or pull request was verified.
3 - wait for reviewer
Znuny, it's your turn.
labels
Sep 28, 2021
dennykorsukewitz
requested changes
Sep 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @BuTzZ,
i created a suggestion for you. ChangedPrio
to 9101.
If you want, you can also activate this Navigation by default. Valid="1"
<Setting Name="Frontend::Navigation###AdminCustomerUserCustomer###001-Framework" Required="0" Valid="1">
keep up the good work 😃 🚀 👍🏼
dennykorsukewitz
added
3 - wait for contributor
Contributor, it's your turn.
and removed
3 - wait for reviewer
Znuny, it's your turn.
labels
Sep 28, 2021
Changed Prio to 9101 Co-authored-by: Denny Korsukéwitz <dennykorsukewitz@gmail.com>
AdminCustomerUserCustomer is now enabled by default
dennykorsukewitz
approved these changes
Sep 29, 2021
dennykorsukewitz
approved these changes
Sep 29, 2021
dennykorsukewitz
added
3 - wait for merge
Znuny, it's your turn.
and removed
3 - wait for contributor
Contributor, it's your turn.
labels
Sep 29, 2021
dennykorsukewitz
added a commit
that referenced
this pull request
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
1 - 🚀 feature
New feature or request
2 - Frontend
4 - verified
This issue or pull request was verified.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no initial config for this module. I tried to set it by using the web frontend, but then Prio didn't work for me (had no effect), maybe special case in my system.
But I think it would be fine if there is an inital config for it.
Proposed change
Just added initial config for Frontend::Navigation###AdminCustomerUserCustomer###1-Framework
1 - 💎 code quality
Breaking change
Additional information
Checklist