Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wrong otrs.Daemon.pl exit code after valid termination #401

Open
wants to merge 2 commits into
base: rel-6_5-dev
Choose a base branch
from

Conversation

pboguslawski
Copy link
Contributor

Proposed change

When otrs.Daemon.pl daemon process receives INT signal to terminate (i.e. from "otrs.Daemon.pl stop" command) it exits with code 1 not 0 as it should. This mod fixes it.

To reproduce try starting with --foreground option introduced in #399 and then stopping daemon and watch daemon process exit code.

Type of change

  • '1 - 🐞 bug 🐞' - Bugfix (non-breaking change which fixes an issue)

Additional information

Related: #109 (comment)
Related: #399
Author-Change-Id: IB#1110219

Checklist

  • The code change is tested and works locally.(❗)
  • There is no commented out code in this PR.(❕)
  • You improved or added new unit tests.(❕)
  • Local ZnunyCodePolicy passed.(❕)
  • Local UnitTests / Selenium passed.(❕)
  • GitHub workflow CI (UnitTests / Selenium) passed.(❗)

When otrs.Daemon.pl daemon process receives INT signal to terminate
(i.e. from "otrs.Daemon.pl stop" command) it exits with code 1 not 0
as it should.

This mod fixes it.

To reporduce try start with --foreground option introduced in
znuny#399 and then stop.

Related: znuny#109 (comment)
Related: znuny#399
Author-Change-Id: IB#1110219
Author-Change-Id: IB#1110219
@dennykorsukewitz dennykorsukewitz added the 1 - 🐞 bug 🐞 An issue with the system. label Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - 🐞 bug 🐞 An issue with the system.
Development

Successfully merging this pull request may close these issues.

2 participants