Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sector Nord AG: Fix for merging of tickets with AgentTicketBulk #535

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

LuBroering
Copy link
Contributor

Proposed change

Creating only one article on ticket merge with AgentTicketBulk. This will resolve the Problem of having one article per merged ticket.

  • '1 - 🐞 bug 🐞' - Bugfix (non-breaking change which fixes an issue)
  • '1 - 💎 code quality' - Code quality improvements to existing code or addition of unit tests

Checklist

  • The code change is tested and works locally.(❗)
  • There is no commented out code in this PR.(❕)
  • You improved or added new unit tests.(❕)
  • Local ZnunyCodePolicy passed.(❕)
  • Local UnitTests / Selenium passed.(❕)
  • GitHub workflow CI (UnitTests / Selenium) passed.(❗)

@NiklasSchmitt
Copy link
Contributor

Hi @LuBroering,

thanks a lot for your contribution.
Currently is the Znuny Code Policy failing for your pr. Please check and verify your code again.

Thanks,
Niklas

@NiklasSchmitt NiklasSchmitt added the 3 - wait for contributor Contributor, it's your turn. label Feb 22, 2024
@LuBroering
Copy link
Contributor Author

Hello @NiklasSchmitt ,
as far as I can see it is failing as the unchanged parts of the code aren't up to the Znuny Code Policy, or am I missing something?

@NiklasSchmitt
Copy link
Contributor

I'm sorry, but sometimes our code policy is a bit ... fussy ...

$ git codePolicy Kernel/Modules/AgentTicketBulk.pm
================================================================================
Code policy context:         Framework
Vendor:                      Znuny GmbH
Product name:                Znuny
================================================================================
Using up to 6 parallel processes.

Kernel/Modules/AgentTicketBulk.pm
    [File was tidied]
    [Warning] ...
    ...
================================================================================
Summary
================================================================================
[Warning] (1)
        (4) Kernel/Modules/AgentTicketBulk.pm
[Tidied] (1)
        Kernel/Modules/AgentTicketBulk.pm
================================================================================
1 of 1 files were tidied or have warnings/errors.

diff:

$ git diff
diff --git a/Kernel/Modules/AgentTicketBulk.pm b/Kernel/Modules/AgentTicketBulk.pm
index 5e3a43aed5..c2096d28df 100644
--- a/Kernel/Modules/AgentTicketBulk.pm
+++ b/Kernel/Modules/AgentTicketBulk.pm
@@ -1325,7 +1325,7 @@ sub Run {
 
         # only create one Article and time for merging
         # add note
-        if ( $MainTicketID ) {
+        if ($MainTicketID) {
             my $ArticleID;
             if (
                 $GetParam{'Subject'}

@LuBroering
Copy link
Contributor Author

@NiklasSchmitt my bad didn't see that. Updated it

@dennykorsukewitz dennykorsukewitz removed the 3 - wait for contributor Contributor, it's your turn. label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants