Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sector Nord AG: Fixed overflow of dynamic field groups in AgentTicketZoom process widget #553

Conversation

jsinagowitz
Copy link
Contributor

Proposed change

If the value of a dynamic field is too long, the dynamic field widgets overflows to the right.

image

Steps to reproduce:

  • Add a process to the process management. The process has to include at least an activity dialog with three dynamic fields. One field should be a textarea.
  • Add the dynamic fields to Ticket::Frontend::AgentTicketZoom###ProcessWidgetDynamicField
  • (Optional) Add three dynamic fields to a group: Ticket::Frontend::AgentTicketZoom###ProcessWidgetDynamicFieldGroups
  • Create a process ticket, use a long text for the textarea field. (I added my text below)
  • Go to the AgentTicketZoom mask and the widget should now look like my screenshot.

It is interesting to note that as soon as any widget contains text that is too large, all the widgets no longer adapts to the window size.

The same widget with a shorter text:

image

  • There may be different ways to fix the issue. I found the CSS class CutValue that was used in the AgentTicketZoom.tt. In the CSS file Core.Agent.TicketProcess.css the class CutValue was commented out before, so I recycled it.
  • You can also reproduce the bug with normal sized Full HD monitors if you use four dynamic fields in the widget. (So it is not just a problem for small monitor users! 😄 )

My example text:

Znuny is the continuation of the OTRS Project created in 2001 by Martin Edenhofer. OTRS AG discontinued maintenance of the ((OTRS)) Community Edition in 2020. Martin’s company Znuny GmbH then forked the project to continue it under the name Znuny.

Since then the software has continued to grow, as never before, through contributions from many open-source support vendors and the hard work and financial backing from Znuny GmbH.

Type of change

  • '1 - 🐞 bug 🐞'

Additional information

I also found the following code snippet in the AgentTicketZoom.tt:

                                        <p class="ValueLong">
[% RenderBlockStart("ProcessWidgetDynamicFieldValueLong") %]
                                            [% Data.Value %]
[% RenderBlockEnd("ProcessWidgetDynamicFieldValueLong") %]
                                        </p>

I did not find the perl code that inserts the blocks. The code may be unnecessary.

Checklist

  • The code change is tested and works locally.(❗)
  • There is no commented out code in this PR.(❕)
  • You improved or added new unit tests.(❕)
  • Local ZnunyCodePolicy passed.(❕)
  • Local UnitTests / Selenium passed.(❕)
  • GitHub workflow CI (UnitTests / Selenium) passed.(❗)

@jsinagowitz jsinagowitz changed the title Fixed overflow of dynamic field groups in AgentTicketZoom process widget Sector Nord AG: Fixed overflow of dynamic field groups in AgentTicketZoom process widget Apr 3, 2024
@jsinagowitz
Copy link
Contributor Author

@dennykorsukewitz Hi, do you have any updates for this PR?

@dennykorsukewitz dennykorsukewitz self-assigned this Aug 17, 2024
@dennykorsukewitz dennykorsukewitz added 3 - wait for reviewer Znuny, it's your turn. GUI 4 - verified This issue or pull request was verified. labels Aug 17, 2024
Copy link
Member

@dennykorsukewitz dennykorsukewitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jsinagowitz ,

thanks for your PR.

Description: ✅
Steps to reproduce: ✅
Example text: ✅

Approved 👍

Regards 🚀

@dennykorsukewitz dennykorsukewitz added Znuny Feature and removed 3 - wait for reviewer Znuny, it's your turn. labels Aug 21, 2024
@dennykorsukewitz dennykorsukewitz added this to the rel-7_1_3 milestone Aug 21, 2024
@dennykorsukewitz dennykorsukewitz merged commit 7f31d0e into znuny:dev Aug 21, 2024
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified This issue or pull request was verified. GUI
Development

Successfully merging this pull request may close these issues.

2 participants