-
Notifications
You must be signed in to change notification settings - Fork 69
fix: respect encoded slashes in redirect header #4328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: ac892247 <a.chmelo@gmail.com>
Signed-off-by: ac892247 <a.chmelo@gmail.com>
apiml-common/src/main/java/org/zowe/apiml/product/routing/transform/TransformService.java
Outdated
Show resolved
Hide resolved
gateway-service/src/main/java/org/zowe/apiml/gateway/filters/PageRedirectionFilterFactory.java
Outdated
Show resolved
Hide resolved
integration-tests/src/test/java/org/zowe/apiml/integration/proxy/RedirectTest.java
Outdated
Show resolved
Hide resolved
integration-tests/src/test/java/org/zowe/apiml/integration/proxy/RedirectTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: ac892247 <a.chmelo@gmail.com>
integration-tests/src/test/java/org/zowe/apiml/integration/proxy/RedirectTest.java
Outdated
Show resolved
Hide resolved
integration-tests/src/test/java/org/zowe/apiml/integration/proxy/RedirectTest.java
Outdated
Show resolved
Hide resolved
integration-tests/src/test/java/org/zowe/apiml/integration/proxy/RedirectTest.java
Show resolved
Hide resolved
integration-tests/src/test/java/org/zowe/apiml/integration/proxy/RedirectTest.java
Outdated
Show resolved
Hide resolved
|
Maybe we could take care of AT-TLS. This solution doesn't help in using an outbound rule in a service calling the Gateway. |
…route matching Signed-off-by: ac892247 <a.chmelo@gmail.com>
Signed-off-by: ac892247 <a.chmelo@gmail.com>
Signed-off-by: ac892247 <a.chmelo@gmail.com>
Signed-off-by: ac892247 <a.chmelo@gmail.com>
Signed-off-by: ac892247 <a.chmelo@gmail.com>
Signed-off-by: ac892247 <a.chmelo@gmail.com>
|
I understand it's covered in integration tests, but from a developer experience point of view, I find it not optimal that we need to verify the behaviour with integration tests. I'd expect that unit tests should cover these changes |
Signed-off-by: ac892247 <a.chmelo@gmail.com>
Signed-off-by: ac892247 <a.chmelo@gmail.com>
gateway-service/src/main/java/org/zowe/apiml/gateway/filters/PageRedirectionFilterFactory.java
Outdated
Show resolved
Hide resolved
integration-tests/src/test/java/org/zowe/apiml/integration/proxy/RedirectTest.java
Outdated
Show resolved
Hide resolved
integration-tests/src/test/java/org/zowe/apiml/integration/proxy/RedirectTest.java
Outdated
Show resolved
Hide resolved
integration-tests/src/test/java/org/zowe/apiml/integration/proxy/RedirectTest.java
Show resolved
Hide resolved
integration-tests/src/test/java/org/zowe/apiml/integration/proxy/RedirectTest.java
Show resolved
Hide resolved
Signed-off-by: ac892247 <a.chmelo@gmail.com>
Signed-off-by: ac892247 <a.chmelo@gmail.com>
|



Description
Location header, in some cases, is being updated, and encoding is being lost. This change updates the header with respect to the original content of the header
Type of change
Checklist: