action_sheet: Check can_subscribe_group for "Subscribe" confirmation dialog #1887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
cc @alya |
rajveermalviya
approved these changes
Oct 1, 2025
There was a problem hiding this comment.
Thanks @chrisbobbe! LGTM, and tests great.
One thing I noticed is that the dialog is not displayed when un-subscribing through the switch button in the "All channels" screen.
Moving over to Greg's review.
rajveermalviya
added
integration review
|
The string change looks good to me, thanks! |
|
Thanks! Looks good, merging.
Indeed, good point. It looks like that was reported just the other day by a user: #1878. |
…cess This tests the change in cf83c9e / zulip#1822.
gnprice
force-pushed
the
pr-group-based-subscribe-permission
branch
from
b628dd9 to
67eea61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1786.
(Also fill in some test coverage for the change in cf83c9e / #1822.)