action_sheet: Prefix channel name with "#" in a confirmation dialog title #1893
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajveermalviya
approved these changes
Oct 3, 2025
rajveermalviya
added
integration review
gnprice
force-pushed
the
pr-hash-in-confirmation-dialog
branch
from
ba79788 to
410250c
Compare
gnprice
reviewed
Oct 3, 2025
|
|
||
| final dialog = showSuggestedActionDialog(context: pageContext, | ||
| title: zulipLocalizations.unsubscribeConfirmationDialogTitle(subscription.name), | ||
| title: zulipLocalizations.unsubscribeConfirmationDialogTitle('#${subscription.name}'), |
There was a problem hiding this comment.
This should get a matching change in the example for this placeholder in app_en.arb.
…itle See Alya's feedback on zulip#1890: zulip#1890 (comment) > In general, our pattern is to always show a privacy marker or (if > not convenient) a `#` before a channel name. It can be a separate > PR, but can we add that to these confirmation dialogs? Doing this in code, rather than in the translators' source string, because we don't want it to vary by language.
chrisbobbe
force-pushed
the
pr-hash-in-confirmation-dialog
branch
from
410250c to
fd5b9a3
Compare
|
Thanks! Revision pushed. |
|
Thanks! Looks good; merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Alya's feedback on #1890:
#1890 (comment)
Doing this in code, rather than in the translators' source string, because we don't want it to vary by language.