Skip to content

action_sheet: Prefix channel name with "#" in a confirmation dialog title #1893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2025
+3 −3
Merged

action_sheet: Prefix channel name with "#" in a confirmation dialog title #1893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/l10n/app_en.arb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@
"@unsubscribeConfirmationDialogTitle": {
"description": "Title for a confirmation dialog for unsubscribing from a channel.",
"placeholders": {
"channelName": {"type": "String", "example": "mobile"}
"channelName": {"type": "String", "example": "#mobile"}
}
},
"unsubscribeConfirmationDialogMessageCannotResubscribe": "Once you leave this channel, you will not be able to rejoin.",
Expand Down
2 changes: 1 addition & 1 deletion lib/widgets/action_sheet.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,7 +647,7 @@ class UnsubscribeButton extends ActionSheetMenuItemButton {
final zulipLocalizations = ZulipLocalizations.of(pageContext);

final dialog = showSuggestedActionDialog(context: pageContext,
title: zulipLocalizations.unsubscribeConfirmationDialogTitle(subscription.name),
title: zulipLocalizations.unsubscribeConfirmationDialogTitle('#${subscription.name}'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should get a matching change in the example for this placeholder in app_en.arb.

message: zulipLocalizations.unsubscribeConfirmationDialogMessageCannotResubscribe,
destructiveActionButton: true,
actionButtonText: zulipLocalizations.unsubscribeConfirmationDialogConfirmButton);
Expand Down
2 changes: 1 addition & 1 deletion test/widgets/action_sheet_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,7 +599,7 @@ void main() {
await tester.pump();

final (unsubscribeButton, cancelButton) = checkSuggestedActionDialog(tester,
expectedTitle: 'Unsubscribe from ${channel.name}?',
expectedTitle: 'Unsubscribe from #${channel.name}?',
expectedMessage: 'Once you leave this channel, you will not be able to rejoin.',
expectDestructiveActionButton: true,
expectedActionButtonText: 'Unsubscribe');
Expand Down