group-pm: fix colorHashFromString

colorHashFromString() now considers all charecters in the string
it can also now return colors with no red component in it. Also fixed
the cases where the function returned #NaN for very long or
empty strings.

Fixes: #3985

group-pm: fix colorHashFromString

colorHashFromString() now considers all charecters in the string
it can also now return colors with no red component in it. Also fixed
the cases where the function returned #NaN for very long or
empty strings.

Fixes: #3985

src/utils/color.js

@@ -7,12 +7,13 @@ export const foregroundColorFromBackground = (color: ColorValue): 'black' | 'whi
 
 export const colorHashFromString = (name: string): string => {
   let hash = 0;
-  for (let i = 0; i < name.length; i++) {
-    hash = hash * 31 + name.charCodeAt(1);
+  for (let i = 1; i < name.length; i++) {
+    hash = hash * 31 + name.charCodeAt(i);
+    hash %= 0x1000000;
   }
-  let colorHash = hash % 0xffffff;
-  if (colorHash < 0x100000) {
-    colorHash += 0x100000;
-  }
-  return `#${colorHash.toString(16)}`;
+
+  let colorHash = hash.toString(16);
+  colorHash = colorHash.padStart(6, '0');
+
+  return `#${colorHash}`;
 };