-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
compose_pills: Fix long text overflow in DM recipient box. #30287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Removes the fixed height of the input field in compose DM recipient box. This commit makes the behaviour of recipient compose box equal to input pills used else where. Fixes: zulip#27688.
If still necessary, we can also implement character limit for the |
I guess in theory the character limit should match the character limit for the pill. So we'd potentially have a different character limit for users vs. streams, etc. It seems OK to take the max of all the values if it's easier not to customize it for different pill types. |
The screenshots look like an improvement to me! |
One more thing I noticed is that pasting |
I manually tested it and everything looks good to me. One thing I noticed is that when you paste the text, the pasted text shakes a little bit. Although jitter is not related to this PR. |
This happens due to pasting tries to pillify the pasted text. If the pasted text is valid, it forms pills without shaking. |
Good point! Might not be worth worrying about a character limit, then. |
@adnan-td Can you please ping your mentor for review? |
@Ujjawal3 @shubham-padia can you please review this. |
I have looked at the code changes and looks good to me. |
Thanks! @karlstolley any feedback on this one, or is it ready for integration review? |
Great! We're ready for integration review on this; I just tested and this works well with 16/140, so that |
Merged, thanks @adnan-td, @Ujjawal3 and @karlstolley! |
Removes the fixed height of the input field in compose DM recipient box. This commit makes the behaviour of recipient compose box equivalent to input pills used else where.
Fixes: #27688.
Screenshots and screen captures:
Before:
After:
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: