-
-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workaround for duration support on sendCommand set #1159
Conversation
@AlCalzone Could this lead to other kind of issues? Or break old sendCommand? |
🚧 It seems like this PR has lint errors 🚧
I should be able to fix them for you. If you want me to, just comment |
Should I add a check for the type of CC? |
Co-authored-by: Daniel Lando <daniel.sorridi@gmail.com>
@zwave-js-bot fix lint |
🐌 Please wait for the lint check to complete, then try again. |
I'm +1 for this. If so this PR could be closed and this should be handled on zwavejs side |
🚧 It seems like this PR has lint errors 🚧
I should be able to fix them for you. If you want me to, just comment |
Well the idea was to add quick and dirty workaround until real duration support is ready without the need to change the core zwavejs side. But I guess I can take a stab at editing the zwavejs intead. |
Sure but if that change is going to be incompatible with the desired solution we'll end up with a breaking change down the line. |
I see no reason to merge e temporary (breaking) dirty solution, I prefer to wait the support to be added on zwave-js side to allow back compatibility |
This is a workaround for zwave-js/node-zwave-js#1321 that allows setting MultiLevelSwitch with duration parameter via
sendCommand
mqtt topic by specifying second parameter in theset
command as duration seconds.This is not ideal, but it allows us to at least use dimming duration in some way until proper solution is developed (which appears to take a while).