Hlt tau validation update cmssw91 x april2017 #18172

slehti · 2017-04-03T08:37:24Z

New PR to master instead of 91X.

cmsbuild · 2017-04-03T08:37:44Z

A new Pull Request was created by @slehti for master.

It involves the following packages:

DQMOffline/Trigger
HLTriggerOffline/Tau

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@battibass, @mtosi, @jhgoh, @calderona, @HuguesBrun, @trocino, @rociovilar this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here

mtosi · 2017-04-03T08:48:19Z

DQMOffline/Trigger/src/HLTTauDQMOfflineSource.cc

+          const boost::regex probepath(tpset.getUntrackedParameter<std::string>("probe"));
+          std::string xvariable = tpset.getUntrackedParameter<std::string>("xvariable");
+
+          std::string pathNameNum = "";


would it be possible to make use of the TriggerGenericEventFlag [1] ?
(as it is done by DQMOffline/Trigger/plugins/METMonitor.cc)

thanks

[1]
CommonTools/TriggerUtils/interface/GenericTriggerEventFlag.h

it allows, not only to apply HLT selection, but in case of need L1 as well
in addition, it allows to select events based on the DCS status bit, which is very important to clean your analysis from events where part of the detectors are not operating

mtosi · 2017-04-04T10:13:26Z

thanks @slehti !

dmitrijus · 2017-04-04T11:02:01Z

+1

cmsbuild · 2017-04-04T11:02:19Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18907/console Started: 2017/04/04 13:03

cmsbuild · 2017-04-04T11:02:20Z

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

cmsbuild · 2017-04-04T12:38:45Z

+1
Tested at: a64c425
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18172/18907/summary.html

cmsbuild · 2017-04-04T12:38:48Z

Comparison job queued.

cmsbuild · 2017-04-04T14:09:47Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18172/18907/summary.html

davidlange6 · 2017-04-04T14:47:37Z

DQMOffline/Trigger/interface/HLTTauDQMOfflineSource.h

@@ -55,6 +58,10 @@ class HLTTauDQMOfflineSource : public DQMEDAnalyzer {
      edm::EDGetTokenT<LVColl> token;
    };
    std::vector<RefObject> refObjects_;
+    std::vector<edm::ParameterSet> tagAndProbePaths;


Hi @slehti - it doesn't look like this object needs to be member data of the class - it could instead be a local variable?

The size of tagAndProbePaths is used in HLTTauDQMOfflineSource::dqmBeginRun to check if the original dqm should be done or not. So a member is needed, but it can be boolean. Do you prefer boolean, or shall I leave the code as is?

hi @slehti - sorry for my slow answer - seems I missed your response

It looks like you can use
num_genTriggerEventFlag_.size()!=0

instead. if not, indeed, a simple bool is preferred.

in general it is preferable to use not collection.empty() instead of collection.size() != 0

davidlange6 · 2017-04-04T14:48:12Z

DQMOffline/Trigger/interface/HLTTauDQMOfflineSource.h

@@ -55,6 +58,10 @@ class HLTTauDQMOfflineSource : public DQMEDAnalyzer {
      edm::EDGetTokenT<LVColl> token;
    };
    std::vector<RefObject> refObjects_;
+    std::vector<edm::ParameterSet> tagAndProbePaths;
+
+    GenericTriggerEventFlag* num_genTriggerEventFlag_;


Please use unique_ptrs here

cmsbuild · 2017-06-07T15:50:00Z

Pull request #18172 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

slehti · 2017-06-07T15:52:57Z

Changed tagAndProbePaths to be local variable, and added global bool.

Martin-Grunewald · 2017-06-07T15:53:45Z

please test

cmsbuild · 2017-06-07T15:54:05Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20407/console Started: 2017/06/07 17:54

cmsbuild · 2017-06-07T17:05:30Z

+1
Tested at: 8a0c28d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18172/20407/summary.html

cmsbuild · 2017-06-07T17:05:33Z

Comparison job queued.

cmsbuild · 2017-06-07T18:39:50Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18172/20407/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 1711 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 1823855
DQMHistoTests: Total failures: 23598
DQMHistoTests: Total nulls: 125
DQMHistoTests: Total successes: 1799959
DQMHistoTests: Total skipped: 173
DQMHistoTests: Total Missing objects: 0
Checked 94 log files, 14 edm output root files, 23 DQM output files

Martin-Grunewald · 2017-06-08T07:30:30Z

@dmitrijus, @vanbesien, @davidlange6
please sign and integrate....

davidlange6 · 2017-06-08T08:36:27Z

DQMOffline/Trigger/interface/HLTTauDQMOfflineSource.h

@@ -58,7 +58,7 @@ class HLTTauDQMOfflineSource : public DQMEDAnalyzer {
      edm::EDGetTokenT<LVColl> token;
    };
    std::vector<RefObject> refObjects_;
-    std::vector<edm::ParameterSet> tagAndProbePaths;
+    bool tagAndProbe;


hi @slehti - in a follow up PR, please change this to tagAndProbe_. Thanks

fwyzard · 2017-06-08T12:13:55Z

tracked by #19142

This PR includes a backport of the following PRs: - cms-sw#18172 - cms-sw#18950 - cms-sw#18959 - cms-sw#18968 - cms-sw#18971 - cms-sw#19023 - cms-sw#19046 - cms-sw#19078 - cms-sw#19119 - cms-sw#19178 - cms-sw#19290 - cms-sw#19293 - cms-sw#19294 - cms-sw#19490 - cms-sw#19499 - cms-sw#19577 - cms-sw#19585 - cms-sw#19596 - cms-sw#19599 - cms-sw#19627 - cms-sw#19689 - cms-sw#19694 - cms-sw#19703 - cms-sw#19781 - cms-sw#19794 plus the older ones, contained in DQMOffline/Trigger and HLTriggerOffline. It synchronises with CMSSW_9_3_X - DQMServices/ClientConfig - DQMOffline/Configuration - DQMOffline/Trigger - HLTriggerOffline/Btag - HLTriggerOffline/Higgs - HLTriggerOffline/SUSYBSM - HLTriggerOffline/Tau - HLTriggerOffline/Top

slehti added 2 commits April 3, 2017 09:25

HLTTauDQM: added L1 IsoTau

8845d02

First commit of HLTTauDQMTagAndProbePlotter

8a03d4f

cmsbuild added this to the Next CMSSW_9_1_X milestone Apr 3, 2017

cmsbuild added comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels Apr 3, 2017

mtosi reviewed Apr 3, 2017

View reviewed changes

Changed HLTTauDQMTagAndProbePlotter to use GenericTriggerEventFlag

a64c425

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Apr 4, 2017

cmsbuild added tests-started and removed tests-pending labels Apr 4, 2017

cmsbuild added tests-approved and removed tests-started labels Apr 4, 2017

cmsbuild added comparison-available and removed comparison-pending labels Apr 4, 2017

davidlange6 reviewed Apr 4, 2017

View reviewed changes

cmsbuild added comparison-pending dqm-pending pending-signatures tests-pending and removed dqm-approved fully-signed tests-approved labels Jun 7, 2017

cmsbuild added tests-started and removed tests-pending labels Jun 7, 2017

cmsbuild added tests-approved and removed tests-started labels Jun 7, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jun 7, 2017

davidlange6 reviewed Jun 8, 2017

View reviewed changes

davidlange6 merged commit 1afba3b into cms-sw:master Jun 8, 2017

mtosi mentioned this pull request Jun 8, 2017

HLT DQM #19142

Open

slehti mentioned this pull request Jun 14, 2017

Hlt tau validation update cmssw92 x june2017 #19216

Merged

fwyzard mentioned this pull request Jul 28, 2017

backport HLT DQM for menu v2.1 to CMSSW 9.2.x #19961

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hlt tau validation update cmssw91 x april2017 #18172

Hlt tau validation update cmssw91 x april2017 #18172

slehti commented Apr 3, 2017

cmsbuild commented Apr 3, 2017 •

edited by smuzaffar

mtosi Apr 3, 2017

mtosi Apr 3, 2017

mtosi commented Apr 4, 2017

dmitrijus commented Apr 4, 2017

cmsbuild commented Apr 4, 2017 •

edited

cmsbuild commented Apr 4, 2017

cmsbuild commented Apr 4, 2017

cmsbuild commented Apr 4, 2017

cmsbuild commented Apr 4, 2017

davidlange6 Apr 4, 2017

slehti Apr 5, 2017

davidlange6 May 10, 2017

fwyzard Jun 7, 2017

davidlange6 Apr 4, 2017

cmsbuild commented Jun 7, 2017

slehti commented Jun 7, 2017

Martin-Grunewald commented Jun 7, 2017

cmsbuild commented Jun 7, 2017 •

edited

cmsbuild commented Jun 7, 2017

cmsbuild commented Jun 7, 2017

cmsbuild commented Jun 7, 2017

Martin-Grunewald commented Jun 8, 2017

davidlange6 Jun 8, 2017

fwyzard commented Jun 8, 2017

Hlt tau validation update cmssw91 x april2017 #18172

Hlt tau validation update cmssw91 x april2017 #18172

Conversation

slehti commented Apr 3, 2017

cmsbuild commented Apr 3, 2017 • edited by smuzaffar

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mtosi commented Apr 4, 2017

dmitrijus commented Apr 4, 2017

cmsbuild commented Apr 4, 2017 • edited

cmsbuild commented Apr 4, 2017

cmsbuild commented Apr 4, 2017

cmsbuild commented Apr 4, 2017

cmsbuild commented Apr 4, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cmsbuild commented Jun 7, 2017

slehti commented Jun 7, 2017

Martin-Grunewald commented Jun 7, 2017

cmsbuild commented Jun 7, 2017 • edited

cmsbuild commented Jun 7, 2017

cmsbuild commented Jun 7, 2017

cmsbuild commented Jun 7, 2017

Martin-Grunewald commented Jun 8, 2017

Choose a reason for hiding this comment

fwyzard commented Jun 8, 2017

cmsbuild commented Apr 3, 2017 •

edited by smuzaffar

cmsbuild commented Apr 4, 2017 •

edited

cmsbuild commented Jun 7, 2017 •

edited