Exo trigger prompt monitoring92 x #18971

gomber · 2017-05-26T18:27:57Z

No description provided.

cmsbuild · 2017-05-26T18:28:15Z

A new Pull Request was created by @gomber for master.

It involves the following packages:

Calibration/HcalAlCaRecoProducers
DQMOffline/Trigger

@ghellwig, @arunhep, @cerminar, @dmitrijus, @cmsbuild, @franzoni, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @battibass, @mtosi, @jhgoh, @calderona, @HuguesBrun, @tocheng, @mmusich, @trocino, @rociovilar this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

mtosi · 2017-05-26T18:33:29Z

DQMOffline/Trigger/plugins/PhotonMonitor.cc

+  histname = "photon_eta"; histtitle = "Photon eta";
+  bookME(ibooker,photonEtaME_,histname,histtitle, phi_binning_1.nbins, phi_binning_1.xmin, phi_binning_1.xmax);
+  setTitle(photonEtaME_,"Photon #eta","events / 0.1");
+


aren't you missing the 2D plot ?

which 2D plots you want? i am just making trigger efficiency plot as a function of pt, eta and phi, so that should be enough

in addition, are you planning to add variables for the "out-of-time" photon ?

I mean having eta and phi 1D plot is sufficient. And yes we would like to add out-of-time photons variable for displaced photons, but later.

mtosi · 2017-05-26T18:34:42Z

DQMOffline/Trigger/python/PhotonMonitor_cff.py

+#HLT_SinglePhoton200_IDTight
+SinglePhoton300_monitoring = hltPhotonmonitoring.clone()
+SinglePhoton300_monitoring.FolderName = cms.string('HLT/Photon/Photon300/')
+SinglePhoton300_monitoring.numGenericTriggerEventPSet.hltPaths = cms.vstring("HLT_Photon300_NoHE_v")


aren't you apply any offline selection ?

mtosi · 2017-05-26T18:34:47Z

DQMOffline/Trigger/python/PhotonMonitor_cff.py

+# HLT_SinglePhoton175_IDTight
+SinglePhoton175_monitoring = hltPhotonmonitoring.clone()
+SinglePhoton175_monitoring.FolderName = cms.string('HLT/Photon/Photon175/')
+SinglePhoton175_monitoring.numGenericTriggerEventPSet.hltPaths = cms.vstring("HLT_Photon175_v*")


aren't you apply any offline selection ?

there is photonselection in the python file photonMonitoring_cfi, which will be created from .cc file.
desc.addstd::string("photonSelection", "pt > 145 && eta<1.4442 && hadTowOverEm<0.0597 && full5x5_sigmaIetaIeta()<0.01031 && chargedHadronIso<1.295");

mtosi · 2017-05-26T18:40:26Z

efficiency in the eta-phi plane ;) mia

…

On Fri, May 26, 2017 at 8:37 PM, gomber ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In DQMOffline/Trigger/plugins/PhotonMonitor.cc <#18971 (comment)>: > + bookME(ibooker,photonME_variableBinning_,histname,histtitle,photon_variable_binning_); + setTitle(photonME_variableBinning_,"Photon pT [GeV]","events / [GeV]"); + + histname = "photonVsLS"; histtitle = "photon pt vs LS"; + bookME(ibooker,photonVsLS_,histname,histtitle,ls_binning_.nbins, ls_binning_.xmin, ls_binning_.xmax,photon_binning_.xmin, photon_binning_.xmax); + setTitle(photonVsLS_,"LS","Photon pT [GeV]"); + + histname = "photon_phi"; histtitle = "Photon phi"; + bookME(ibooker,photonPhiME_,histname,histtitle, phi_binning_1.nbins, phi_binning_1.xmin, phi_binning_1.xmax); + setTitle(photonPhiME_,"Photon #phi","events / 0.1 rad"); + + + histname = "photon_eta"; histtitle = "Photon eta"; + bookME(ibooker,photonEtaME_,histname,histtitle, phi_binning_1.nbins, phi_binning_1.xmin, phi_binning_1.xmax); + setTitle(photonEtaME_,"Photon #eta","events / 0.1"); + which 2D plots you want? i am just making trigger efficiency plot as a function of pt, eta and phi, so that should be enough — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#18971 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEt58wA29CzAZl9O6anrutNFRI-5yEdFks5r9xvrgaJpZM4Nn66Y> .

arunhep · 2017-05-26T18:54:48Z

i think this PR needs rebase.

cmsbuild · 2017-05-26T19:01:41Z

Pull request #18971 was updated. @ghellwig, @arunhep, @cerminar, @dmitrijus, @cmsbuild, @franzoni, @vanbesien, @davidlange6 can you please check and sign again.

cmsbuild · 2017-05-26T19:09:09Z

Pull request #18971 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

gomber · 2017-05-26T19:09:45Z

@arunhep should be fine now..

gomber · 2017-05-26T19:12:02Z

So guys, I am adding 2D plot and will do another commit as Mia suggested and then we would be good to go!

mtosi · 2017-05-26T19:22:20Z

DQMOffline/Trigger/plugins/PhotonMonitor.cc

+
+
+  histname = "photon_eta"; histtitle = "Photon eta";
+  bookME(ibooker,photonEtaME_,histname,histtitle, phi_binning_1.nbins, phi_binning_1.xmin, phi_binning_1.xmax);


shouldn't be eta_binning ?

phi_binning which we are using in the code is very general, and can be used for eta too, its 64 bins between -3.2 to 3.2, thats why used the same variable

Ok I am using the following one now, since we are mainly interested in barrel region for these, so looking at the ECAL tower size, 1.4442/0.087 = ~17 bins, so I will cover -1.4442 to 1.4442 with 34 bins.

mtosi · 2017-05-26T19:23:46Z

DQMOffline/Trigger/plugins/PhotonMonitor.cc

+  fillHistoPSetDescription(metPSet);
+  histoPSet.add<edm::ParameterSetDescription>("photonPSet", metPSet);
+  std::vector<double> bins = {0.,20.,40.,60.,80.,90.,100.,110.,120.,130.,140.,150.,160.,170.,180.,190.,200.,220.,240.,260.,280.,300.,350.,400.,450.,1000.};
+  histoPSet.add<std::vector<double> >("photonBinning", bins);


I think you should overwrite this in the python config
taking into account the expected turnON

mtosi · 2017-05-26T19:56:39Z

please use the more appropriate for photon obj thanks mia

…

On Fri, May 26, 2017 at 9:52 PM, gomber ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In DQMOffline/Trigger/plugins/PhotonMonitor.cc <#18971 (comment)>: > + + histname = "photon_pt_variable"; histtitle = "photon PT"; + bookME(ibooker,photonME_variableBinning_,histname,histtitle,photon_variable_binning_); + setTitle(photonME_variableBinning_,"Photon pT [GeV]","events / [GeV]"); + + histname = "photonVsLS"; histtitle = "photon pt vs LS"; + bookME(ibooker,photonVsLS_,histname,histtitle,ls_binning_.nbins, ls_binning_.xmin, ls_binning_.xmax,photon_binning_.xmin, photon_binning_.xmax); + setTitle(photonVsLS_,"LS","Photon pT [GeV]"); + + histname = "photon_phi"; histtitle = "Photon phi"; + bookME(ibooker,photonPhiME_,histname,histtitle, phi_binning_1.nbins, phi_binning_1.xmin, phi_binning_1.xmax); + setTitle(photonPhiME_,"Photon #phi","events / 0.1 rad"); + + + histname = "photon_eta"; histtitle = "Photon eta"; + bookME(ibooker,photonEtaME_,histname,histtitle, phi_binning_1.nbins, phi_binning_1.xmin, phi_binning_1.xmax); phi_binning which we are using in the code is very general, and can be used for eta too, its 64 bins between -3.2 to 3.2, thats why used the same variable — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#18971 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEt582Eadk-RrjLO2v4U4KsIw5-ym2VRks5r9y17gaJpZM4Nn66Y> .

mtosi · 2017-05-29T08:52:59Z

DQMOffline/Trigger/plugins/PhotonMonitor.cc

+  photonME_variableBinning_.denominator = nullptr;
+  photonVsLS_.numerator   = nullptr;
+  photonVsLS_.denominator = nullptr;
+  photonEtaME_.numerator   = nullptr;


I think the variable binning should be used for eta as well

are you going to add the variable binning for properly handle the ECAL geometry ?

mtosi · 2017-05-29T08:53:18Z

DQMOffline/Trigger/plugins/PhotonMonitor.cc

+  photonEtaME_.denominator = nullptr;
+  photonPhiME_.numerator   = nullptr;
+  photonPhiME_.denominator = nullptr;
+


I would suggest to add the 2D plot
and H/E and probably R9

mtosi · 2017-05-29T10:49:58Z

DQMOffline/Trigger/python/PhotonMonitor_cff.py

+Photon60_monitoring = hltPhotonmonitoring.clone()
+Photon60_monitoring.FolderName = cms.string('HLT/Photon/Photon60/')
+Photon60_monitoring.denGenericTriggerEventPSet.hltPaths = cms.vstring()
+Photon60_monitoring.numGenericTriggerEventPSet.hltPaths = cms.vstring("HLT_Photon60_R9Id90_CaloIdL_IsoL_v*")


are you sure it is available in 2017 ?

yes it is available kevin requested them
https://its.cern.ch/jira/browse/CMSHLT-1327

mtosi · 2017-05-29T10:51:06Z

DQMOffline/Trigger/python/PhotonMonitor_cff.py

+
+Photon60_DisplacedIdL_PFJet350MinPFJet15_monitoring = Photon60_DisplacedIdL_monitoring.clone()
+Photon60_DisplacedIdL_PFJet350MinPFJet15_monitoring.FolderName = cms.string('HLT/Photon/Photon60_DisplacedIdL_PFJet350MinPFJet15/')
+Photon60_DisplacedIdL_PFJet350MinPFJet15_monitoring.denGenericTriggerEventPSet.hltPaths = cms.vstring("HLT_Photon60_R9Id90_CaloIdL_IsoL_v*","HLT_PFHT350MinPFJet15_v*")


are you sure they are available ?

see previous message

mtosi · 2017-05-29T11:13:45Z

what about
HLT_Photon50_R9Id90_HE10_IsoM_v8
HLT_Photon75_R9Id90_HE10_IsoM_v8
HLT_Photon90_R9Id90_HE10_IsoM_v8
HLT_Photon120_R9Id90_HE10_IsoM_v8
HLT_Photon165_R9Id90_HE10_IsoM_v9

gomber · 2017-05-29T15:36:31Z

Hi Mia,

who requested these paths, I didn't see it in Sam mails, may be I missed it?
And I thought the idea of prompt monitoring is for signal paths, so that we can find the issues (if any) fast. Another question, i assume these paths are prescale?

Regards
Bhawna

fwyzard · 2017-05-29T16:38:16Z

We need monitoring for all triggers.

cmsbuild · 2017-07-02T16:21:49Z

Pull request #18971 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please check and sign again.

gomber · 2017-07-02T16:22:41Z

@dmitrijus please test again, there was one small bug in the photon_cff file, which i fixed, looks like some typo happened in the last round.

gomber · 2017-07-02T16:38:06Z

@fwyzard here it is #19506

gomber · 2017-07-03T08:17:34Z

@davidlange6 Regarding the number of bins, we have 16 histograms which corresponds to 2900 bins in total and then there are 10 instances of it, so that would mean in total this code would add 29000 bins, if this is the kind of information you asked me.

fwyzard · 2017-07-03T08:57:40Z

@cmsbuild, please test

cmsbuild · 2017-07-03T08:57:58Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21073/console Started: 2017/07/03 10:59

cmsbuild · 2017-07-03T10:10:02Z

+1
Tested at: 842acda
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18971/21073/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
b1580cd
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18971/21073/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18971/21073/git-merge-result

cmsbuild · 2017-07-03T10:10:05Z

Comparison job queued.

cmsbuild · 2017-07-03T12:06:38Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18971/21073/summary.html

Comparison Summary:

You potentially added 10 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 22
DQMHistoTests: Total histograms compared: 1756063
DQMHistoTests: Total failures: 102
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1755795
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 90 log files, 14 edm output root files, 22 DQM output files

gomber · 2017-07-03T14:07:20Z

@davidlange6 Could you please proceed with this? as all the tests are passed and we also provide nbins information?

davidlange6 · 2017-07-03T14:59:25Z

all that happened a few hours ago:)

davidlange6 · 2017-07-03T14:59:29Z

merge

This PR includes a backport of the following PRs: - cms-sw#18172 - cms-sw#18950 - cms-sw#18959 - cms-sw#18968 - cms-sw#18971 - cms-sw#19023 - cms-sw#19046 - cms-sw#19078 - cms-sw#19119 - cms-sw#19178 - cms-sw#19290 - cms-sw#19293 - cms-sw#19294 - cms-sw#19490 - cms-sw#19499 - cms-sw#19577 - cms-sw#19585 - cms-sw#19596 - cms-sw#19599 - cms-sw#19627 - cms-sw#19689 - cms-sw#19694 - cms-sw#19703 - cms-sw#19781 - cms-sw#19794 plus the older ones, contained in DQMOffline/Trigger and HLTriggerOffline. It synchronises with CMSSW_9_3_X - DQMServices/ClientConfig - DQMOffline/Configuration - DQMOffline/Trigger - HLTriggerOffline/Btag - HLTriggerOffline/Higgs - HLTriggerOffline/SUSYBSM - HLTriggerOffline/Tau - HLTriggerOffline/Top

cmsbuild added this to the CMSSW_9_2_X milestone May 26, 2017

cmsbuild added alca-pending comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels May 26, 2017

mtosi reviewed May 26, 2017

View reviewed changes

gomber force-pushed the EXOTrigger_promptMonitoring92X branch from ea01396 to 65b8733 Compare May 26, 2017 19:08

cmsbuild removed the alca-pending label May 26, 2017

mtosi reviewed May 26, 2017

View reviewed changes

mplaner mentioned this pull request May 27, 2017

Updating HLT DQM and validation for Hgg paths #18979

Closed

mtosi reviewed May 29, 2017

View reviewed changes

cmsbuild added comparison-pending tests-pending labels Jul 2, 2017

gomber mentioned this pull request Jul 2, 2017

Exo trigger prompt monitoring92 x #19506

Closed

cmsbuild added tests-started and removed tests-pending labels Jul 3, 2017

cmsbuild added tests-approved and removed tests-started labels Jul 3, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jul 3, 2017

gomber mentioned this pull request Jul 3, 2017

Photon monitoring in 92x release #19520

Closed

cmsbuild merged commit 526d318 into cms-sw:master Jul 3, 2017

This was referenced Jul 3, 2017

(Replacement of #19372) Add DisplacedJet Paths Offline DQM #19487

Closed

Adding HLT_Ele50_CaloIdVT_GsfTrkIdT_PFJet165_v* to B2G HLT Monitoring #19407

Closed

jingyuluo added a commit to jingyuluo/cmssw that referenced this pull request Jul 4, 2017

resolve the conficts with cms-sw#18971

0b11820

fwyzard mentioned this pull request Jul 28, 2017

backport HLT DQM for menu v2.1 to CMSSW 9.2.x #19961

Closed



		histname = "photon_eta"; histtitle = "Photon eta";
		bookME(ibooker,photonEtaME_,histname,histtitle, phi_binning_1.nbins, phi_binning_1.xmin, phi_binning_1.xmax);

Exo trigger prompt monitoring92 x #18971

Exo trigger prompt monitoring92 x #18971

Conversation

gomber commented May 26, 2017

cmsbuild commented May 26, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gomber May 26, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mtosi commented May 26, 2017 via email

arunhep commented May 26, 2017

cmsbuild commented May 26, 2017

cmsbuild commented May 26, 2017

gomber commented May 26, 2017

gomber commented May 26, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mtosi commented May 26, 2017 via email

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mtosi May 29, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mtosi commented May 29, 2017

gomber commented May 29, 2017

fwyzard commented May 29, 2017

cmsbuild commented Jul 2, 2017

gomber commented Jul 2, 2017

gomber commented Jul 2, 2017

gomber commented Jul 3, 2017

fwyzard commented Jul 3, 2017

cmsbuild commented Jul 3, 2017 • edited

cmsbuild commented Jul 3, 2017

cmsbuild commented Jul 3, 2017

cmsbuild commented Jul 3, 2017

gomber commented Jul 3, 2017

davidlange6 commented Jul 3, 2017

davidlange6 commented Jul 3, 2017

gomber May 26, 2017 •

edited

mtosi May 29, 2017 •

edited

cmsbuild commented Jul 3, 2017 •

edited