Fix NUL characters in FORMAT() output #634
Closed
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugs.mysql.com/bug.php?id=82085
In
sql/sql/locale.ccthere is this forbg_BG:Other locales that set
\0as thousounds separator have grouping set to\x80\x80, but thebg_BGlocale doesn't.The result is that
FORMAT(12345.67,3,'bg_BG')has a NUL character as thousands separator.Before this commit:
With this commit:
Other options considered:
bg_BGto\x80\x80. This would probably have the same result, but allows for newly added locales to have the same issue later on.bg_BGto(space, 0x20). This would result in output that may be visually similar depending on the client, but it seems like no thousands separator was the intended behavior.