Skip to content

Fea/sidebar api change#262

Merged
rapids-bot[bot] merged 23 commits intorapidsai:branch-0.19from
AjayThorve:fea/sidebar-api-change
Apr 7, 2021
Merged

Fea/sidebar api change#262
rapids-bot[bot] merged 23 commits intorapidsai:branch-0.19from
AjayThorve:fea/sidebar-api-change

Conversation

@AjayThorve
Copy link
Copy Markdown
Member

@AjayThorve AjayThorve commented Apr 6, 2021 •
edited
Loading

This PR

  1. Implements a sidebar api for dashboard function, closes [FEA] API change for Panel Widget #256 :
d = cux_df.dashboard(charts=charts_list, sidebar=[widget_chart1, widget_chart2], layout_array=[
    [1, 1, 2, 2],
    [1, 1, 3, 4]
], theme=cuxfilter.themes.rapids, title="Layout - Custom")
  1. fixes [BUG] Layout Card Move Icon Hidden #259
  2. minor refactors wherever possible to use f-strings
  3. updates docs to reflect sidebar prop usage

@AjayThorve AjayThorve requested a review from a team as a code owner April 6, 2021 07:33
@github-actions github-actions bot added the Python label Apr 6, 2021
@AjayThorve AjayThorve marked this pull request as draft April 6, 2021 07:33
bryevdv
bryevdv reviewed Apr 6, 2021
View reviewed changes
@AjayThorve AjayThorve marked this pull request as ready for review April 6, 2021 20:05
@github-actions github-actions bot added the doc Documentation label Apr 6, 2021
@AjayThorve AjayThorve added feature request New feature or request non-breaking Non-breaking change and removed doc Documentation labels Apr 6, 2021
@github-actions github-actions bot added the doc Documentation label Apr 6, 2021
@AjayThorve AjayThorve removed the feature request New feature or request label Apr 6, 2021
@AjayThorve
Copy link
Copy Markdown
Member Author

AjayThorve commented Apr 6, 2021

@gpucibot merge

@AjayThorve
Copy link
Copy Markdown
Member Author

AjayThorve commented Apr 7, 2021

Rerun tests

@rapids-bot rapids-bot bot merged commit d499b17 into rapidsai:branch-0.19 Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bryevdv bryevdv bryevdv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Documentation non-breaking Non-breaking change Python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Layout Card Move Icon Hidden [FEA] API change for Panel Widget

2 participants

@AjayThorve @bryevdv