Upgrade allocation payer-based logic #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrenerd
changed the title
Sriep
suggested changes
Jun 8, 2021
Contributor
Sriep
left a comment
Sriep
left a comment
There was a problem hiding this comment.
They automatic checks should prevent syntax errors but don't. Issue #195
We need unit tests for modified methods such as blobberGRPCService.GetFileMetaData and StorageHandler.DownloadFile. These tests have not been written yet, but it would add confidence to write the tests here.
code/go/0chain.net/blobbercore/handler/object_operation_handler.go
Outdated
Show resolved
Hide resolved
Contributor
|
Merge in the latest master changes, as I think that might fix the failing to fail unit test check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.