Fix Windows reload issue (/bin/sh not found) #1389
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds native Windows compatibility for Nginx-UI, fixing the following error when reloading Nginx on
Windows:
Updated execShell in internal/nginx/exec.go
to use cmd /C instead of /bin/sh -c when running on Windows.
This makes ReloadCmd, RestartCmd, and other Nginx commands work properly on Windows environments.
Implementation Detail
Added import "runtime" for OS detection.
Tested Environment
OS: Windows 10 / Windows Server 2019
Nginx: Windows build (nginx.exe)
Result:
Reload and Restart work correctly
UI responds successfully
No /bin/sh errors