feat: add rate limiter for [main]#1763
Merged
Mirko-von-Leipzig merged 8 commits intomainfrom Mar 11, 2026
Merged
Conversation
drahnr
changed the title
main]
drahnr
force-pushed
the
bernhard-feat-add-rate-limiter-for-main
branch
from
06fa8bb to
5ebd3eb
Compare
drahnr
force-pushed
the
bernhard-feat-add-rate-limiter-for-main
branch
from
5ebd3eb to
3fb3019
Compare
drahnr
commented
Mar 10, 2026
| // Build the gRPC server with the API service and trace layer. | ||
|
|
||
| tonic::transport::Server::builder() | ||
| .accept_http1(true) |
Contributor
Author
There was a problem hiding this comment.
Not sure if this slipped through in the other PR too?
Collaborator
There was a problem hiding this comment.
next also has accept_http1(true) if that's what you mean?
drahnr
commented
Mar 10, 2026
| TcpListener::bind("127.0.0.1:0").await.expect("store should bind a port"); | ||
| store_listener.local_addr().expect("store should get a local address") | ||
| }; | ||
| async fn start_rpc() -> (RpcClient, std::net::SocketAddr, TcpListener) { |
Contributor
Author
There was a problem hiding this comment.
The change to retain the port allocation rather than to allocate -> free -> attempt to re-allocate the initial one.
Mirko-von-Leipzig
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Targets
mainPort of #1750 for
main.Also contains #1727 to avoid more test failures due to how we do port allocations for tests