Skip to content

Conversation

@remimd
Copy link
Contributor

@remimd remimd commented Oct 15, 2025

No description provided.

@remimd remimd requested a review from Copilot October 15, 2025 10:00
@remimd remimd self-assigned this Oct 15, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where enums couldn't be used as injectable types in the dependency injection system. The fix adds logic to properly handle enums by ensuring they are not treated as collections during type resolution.

Key changes:

  • Added test coverage for enum injection to verify the fix works correctly
  • Modified type checking logic to exclude class types (including enums) from collection handling

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
tests/test_injectable.py Adds test case to verify enum injection functionality works correctly
injection/_core/common/type.py Fixes type resolution logic to properly handle enums and other class types

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@remimd remimd merged commit e42a9c9 into dev Oct 15, 2025
6 checks passed
@remimd remimd deleted the enums branch October 15, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants