[pull] main from autowarefoundation:main #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
…pping (#2828) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…#2830) * feat(behavior_path_planner): deal with non rectangle object avoidance Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…2829) * fix(behavior_path_planner): fix path distortion of no back pull out Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * Update planning/behavior_path_planner/src/scene_module/utils/geometric_parallel_parking.cpp --------- Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
* chore: sync files Signed-off-by: GitHub <noreply@github.com> * Revert "chore: sync files" This reverts commit f3d23de. * ci(pre-commit): disable autoupdate Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> --------- Signed-off-by: GitHub <noreply@github.com> Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>
* Add a function to check delay step * Apply the delay step checker to twist * Test the delay step cheker
…inning of a string (#2702) * Add a function to remove the begin slash Signed-off-by: IshitaTakeshi <ishitah.takeshi@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -487,13 +481,9 @@ void EKFLocalizer::measurementUpdateTwist( | |||
| delay_time = std::max(delay_time, 0.0); | |||
|
|
|||
| int delay_step = std::roundf(delay_time / ekf_dt_); | |||
There was a problem hiding this comment.
narrowing conversion from double to float
| #include <gtest/gtest.h> | ||
|
|
||
| TEST(PoseDelayStepWarningMessage, SmokeTest) |
There was a problem hiding this comment.
class PoseDelayStepWarningMessage_SmokeTest_Test defines a copy constructor and a copy assignment operator but does not define a destructor, a move constructor or a move assignment operator
| "delay: 6.000[s], limit = extend_state_step * ekf_dt : 4.000[s]"); | ||
| } | ||
|
|
||
| TEST(TwistDelayStepWarningMessage, SmokeTest) |
There was a problem hiding this comment.
class TwistDelayStepWarningMessage_SmokeTest_Test defines a copy constructor and a copy assignment operator but does not define a destructor, a move constructor or a move assignment operator
| "Twist delay exceeds the compensation limit, ignored. " | ||
| "delay: 10.000[s], limit = extend_state_step * ekf_dt : 6.000[s]"); | ||
| } | ||
|
|
||
| TEST(PoseDelayTimeWarningMessage, SmokeTest) |
There was a problem hiding this comment.
class PoseDelayTimeWarningMessage_SmokeTest_Test defines a copy constructor and a copy assignment operator but does not define a destructor, a move constructor or a move assignment operator
| @@ -143,7 +143,7 @@ class BehaviorPathPlannerNode : public rclcpp::Node | |||
| PullOutParameters getPullOutParam(); | |||
There was a problem hiding this comment.
invalid case style for function getPullOutParam
Suggested change
| PullOutParameters getPullOutParam(); | |
| PullOutParameters get_pull_out_param(); |
| @@ -143,7 +143,7 @@ | |||
| PullOutParameters getPullOutParam(); | |||
|
|
|||
| // callback | |||
| void onOdometry(const Odometry::SharedPtr msg); | |||
| void onOdometry(const Odometry::ConstSharedPtr msg); | |||
There was a problem hiding this comment.
invalid case style for function onOdometry
Suggested change
| void onOdometry(const Odometry::ConstSharedPtr msg); | |
| void on_odometry(const Odometry::ConstSharedPtr msg); |
| @@ -143,7 +143,7 @@ | |||
| PullOutParameters getPullOutParam(); | |||
|
|
|||
| // callback | |||
| void onOdometry(const Odometry::SharedPtr msg); | |||
| void onOdometry(const Odometry::ConstSharedPtr msg); | |||
| void onAcceleration(const AccelWithCovarianceStamped::ConstSharedPtr msg); | |||
There was a problem hiding this comment.
invalid case style for function onAcceleration
Suggested change
| void onAcceleration(const AccelWithCovarianceStamped::ConstSharedPtr msg); | |
| void on_acceleration(const AccelWithCovarianceStamped::ConstSharedPtr msg); |
| @@ -143,7 +143,7 @@ | |||
| PullOutParameters getPullOutParam(); | |||
|
|
|||
| // callback | |||
| void onOdometry(const Odometry::SharedPtr msg); | |||
| void onOdometry(const Odometry::ConstSharedPtr msg); | |||
| void onAcceleration(const AccelWithCovarianceStamped::ConstSharedPtr msg); | |||
| void onPerception(const PredictedObjects::ConstSharedPtr msg); | |||
There was a problem hiding this comment.
invalid case style for function onPerception
Suggested change
| void onPerception(const PredictedObjects::ConstSharedPtr msg); | |
| void on_perception(const PredictedObjects::ConstSharedPtr msg); |
| @@ -143,7 +143,7 @@ | |||
| PullOutParameters getPullOutParam(); | |||
|
|
|||
| // callback | |||
| void onOdometry(const Odometry::SharedPtr msg); | |||
| void onOdometry(const Odometry::ConstSharedPtr msg); | |||
| void onAcceleration(const AccelWithCovarianceStamped::ConstSharedPtr msg); | |||
| void onPerception(const PredictedObjects::ConstSharedPtr msg); | |||
| void onOccupancyGrid(const OccupancyGrid::ConstSharedPtr msg); | |||
There was a problem hiding this comment.
invalid case style for function onOccupancyGrid
Suggested change
| void onOccupancyGrid(const OccupancyGrid::ConstSharedPtr msg); | |
| void on_occupancy_grid(const OccupancyGrid::ConstSharedPtr msg); |
| @@ -105,7 +105,7 @@ class PullOutModule : public SceneModuleInterface | |||
| std::shared_ptr<PullOutPlannerBase> getCurrentPlanner() const; | |||
There was a problem hiding this comment.
invalid case style for function getCurrentPlanner
Suggested change
| std::shared_ptr<PullOutPlannerBase> getCurrentPlanner() const; | |
| std::shared_ptr<PullOutPlannerBase> get_current_planner() const; |
| @@ -105,7 +105,7 @@ class PullOutModule : public SceneModuleInterface | |||
| std::shared_ptr<PullOutPlannerBase> getCurrentPlanner() const; | |||
| PathWithLaneId getFullPath() const; | |||
There was a problem hiding this comment.
invalid case style for function getFullPath
Suggested change
| PathWithLaneId getFullPath() const; | |
| PathWithLaneId get_full_path() const; |
| @@ -105,7 +105,7 @@ | |||
| std::shared_ptr<PullOutPlannerBase> getCurrentPlanner() const; | |||
| PathWithLaneId getFullPath() const; | |||
| ParallelParkingParameters getGeometricPullOutParameters() const; | |||
There was a problem hiding this comment.
invalid case style for function getGeometricPullOutParameters
Suggested change
| ParallelParkingParameters getGeometricPullOutParameters() const; | |
| ParallelParkingParameters get_geometric_pull_out_parameters() const; |
| @@ -105,7 +105,7 @@ | |||
| std::shared_ptr<PullOutPlannerBase> getCurrentPlanner() const; | |||
| PathWithLaneId getFullPath() const; | |||
| ParallelParkingParameters getGeometricPullOutParameters() const; | |||
| std::vector<Pose> searchBackedPoses(); | |||
| std::vector<Pose> searchPullOutStartPoses(); | |||
There was a problem hiding this comment.
invalid case style for function searchPullOutStartPoses
Suggested change
| std::vector<Pose> searchPullOutStartPoses(); | |
| std::vector<Pose> search_pull_out_start_poses(); |
| @@ -503,42 +535,8 @@ Polygon2d createEnvelopePolygon( | |||
| tf2::doTransform( | |||
| toMsg(envelope_poly, closest_pose.position.z), envelope_ros_polygon, geometry_tf); | |||
There was a problem hiding this comment.
invalid case style for function toMsg
Suggested change
| toMsg(envelope_poly, closest_pose.position.z), envelope_ros_polygon, geometry_tf); | |
| to_msg(envelope_poly, closest_pose.position.z), envelope_ros_polygon, geometry_tf); |
| @@ -232,6 +232,38 @@ | |||
| return x1; | |||
| } | |||
|
|
|||
| tier4_autoware_utils::Polygon2d expandPolygon( | |||
There was a problem hiding this comment.
invalid case style for function expandPolygon
Suggested change
| tier4_autoware_utils::Polygon2d expandPolygon( | |
| tier4_autoware_utils::Polygon2d expand_polygon( |
| const auto edge_point = tier4_autoware_utils::createPoint(curr_p.x(), curr_p.y(), 0.0); | ||
| edge_points.push_back(edge_point); | ||
| } | ||
| const auto expanded_polygon = expandPolygon(toPolygon2d(envelope_ros_polygon), envelope_buffer); |
There was a problem hiding this comment.
invalid case style for function expandPolygon
Suggested change
| const auto expanded_polygon = expandPolygon(toPolygon2d(envelope_ros_polygon), envelope_buffer); | |
| const auto expanded_polygon = expand_polygon(toPolygon2d(envelope_ros_polygon), envelope_buffer); |
| const auto edge_point = tier4_autoware_utils::createPoint(curr_p.x(), curr_p.y(), 0.0); | ||
| edge_points.push_back(edge_point); | ||
| } | ||
| const auto expanded_polygon = expandPolygon(toPolygon2d(envelope_ros_polygon), envelope_buffer); |
There was a problem hiding this comment.
invalid case style for variable toPolygon2d
Suggested change
| const auto expanded_polygon = expandPolygon(toPolygon2d(envelope_ros_polygon), envelope_buffer); | |
| const auto expanded_polygon = expandPolygon(to_polygon2d(envelope_ros_polygon), envelope_buffer); |
| edge_points.push_back(edge_point); | ||
| } | ||
| const auto expanded_polygon = expandPolygon(toPolygon2d(envelope_ros_polygon), envelope_buffer); | ||
| return expanded_polygon; |
There was a problem hiding this comment.
constness of expanded_polygon prevents automatic move
…ance path (#2833) * fix(behavior_path_planner): fix drivable area for long backawrd avoidance path Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
* fix(lane_change): get sorted lane ids Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * slightly change the find Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
* fix(lane_change): safe intervehicle distance in collision check Signed-off-by: Muhammad Zulfaqar <zulfaqar.azmi@tier4.jp> * fix spellcheck Signed-off-by: Muhammad Zulfaqar <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…er (#2388) Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
* feat(simple_planning_sim): publish sensing interface imu data Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> * fix covariance index Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> --------- Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
…e intersection (#2861) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
* fix(behavior_path_planner): fix overlapping checker Signed-off-by: yutaka <purewater0901@gmail.com> * fix format Signed-off-by: yutaka <purewater0901@gmail.com> --------- Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…rint (#2870) * refactor(tier4_planning_rviz_plugin): create abstract class for footprint Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
* refactor(tier4_planning_rviz_plugin): clean up the code of path Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
#2845) * feat(tier4_perception_launch): update cam/lidar detection architecture Signed-off-by: Kaan Çolak <kaancolak95@gmail.com> * style(pre-commit): autofix --------- Signed-off-by: Kaan Çolak <kaancolak95@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…closing circle (#2846) * perf(detection_area): point and polygon inclusion check by minimum enclosing circle Signed-off-by: veqcc <ryuta.kambe@tier4.jp> * style(pre-commit): autofix * Update planning/behavior_velocity_planner/src/scene_module/detection_area/scene.cpp Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> * style(pre-commit): autofix * Update planning/behavior_velocity_planner/src/scene_module/detection_area/scene.cpp * Update planning/behavior_velocity_planner/src/scene_module/detection_area/scene.cpp Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> * Update planning/behavior_velocity_planner/src/scene_module/detection_area/scene.cpp Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> * Update planning/behavior_velocity_planner/src/scene_module/detection_area/scene.cpp * Update planning/behavior_velocity_planner/src/scene_module/detection_area/scene.cpp * style(pre-commit): autofix * style(pre-commit): autofix --------- Signed-off-by: veqcc <ryuta.kambe@tier4.jp> Co-authored-by: veqcc <ryuta.kambe@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
…s judge (#2859) * fix(behavior_velocity_planner): check if over pass judge line after collision checking Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * fix(behavior_velocity_planner): revert part of #2719 Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> --------- Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…th same parent and same direction (#2874) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…e intersection (#2862) * fix(behavior_path_planner): deal with edge case of drivable area expansion Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…ency (#2869) Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
* fix(doc/link): update apollo documentation link
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
* fix(doc/link): fix internal link
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
* chore(doc): comment-out a figure that does not exist
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
* chore(doc): add {} to avoid recognize as a markdown link
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
* chore(doc): add {} to avoid recognize as a markdown link
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
* chore(doc): fix the hash of apollo link
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
* chore(doc): fix the hash of apollo link
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
* chore(doc): replace TierIV with TIER IV
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
---------
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
github-actions
bot
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )