Java sprint 8 v1.0 #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
В классе Task и его наследниках были добавлены переменные startTime, duration, endTime. В классе FileBackedTaskManager добавлены поля для времени старта и продолжительности. 2 forEach переделаны под Stream API в классе InMemoryTaskManager
Подкорректировал код
YazykovMikhail
suggested changes
Jun 7, 2024
YazykovMikhail
left a comment
YazykovMikhail
left a comment
There was a problem hiding this comment.
Так же есть пункт в задании:
"Покрываем код тестами"
Стоит его выполнить
src/ru/yandex/javacource/golotin/schedule/service/InMemoryTaskManager.java
Show resolved
Hide resolved
src/ru/yandex/javacource/golotin/schedule/service/InMemoryTaskManager.java
Show resolved
Hide resolved
исправлен startTime,duration. Поправлена работа файлового менеджера. Дописал тест к новым методам менеджера. Также добавил класс тест для файлового менеджера.
YazykovMikhail
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
В классе Task и его наследниках были добавлены переменные startTime, duration, endTime. В классе FileBackedTaskManager добавлены поля для времени старта и продолжительности. 2 forEach переделаны под Stream API в классе InMemoryTaskManager. Также добавлен TreeSet prioritizedTasks с методо для поиска пересечений во времени addPriorityTask