Статус поддержки: учет общего уровня "замка" #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theshadowco
reviewed
Dec 4, 2020
src/main/java/com/github/_1c_syntax/mdclasses/metadata/additional/ParseSupportData.java
Outdated
Show resolved
Hide resolved
nixel2007
reviewed
Dec 4, 2020
| var guidObject = dataStrings[currentObjectPoint + 2]; | ||
| var supportVariant = getSupportVariantByInt(support); | ||
| SupportVariant supportVariant; | ||
| if (configurationSupportVariant == SupportVariant.EDITABLE_SUPPORT_ENABLED) { |
There was a problem hiding this comment.
я в детали не углублялся, но тут точно ==?
There was a problem hiding this comment.
я не про сравнение как таковое, а про == или !=
There was a problem hiding this comment.
@nixel2007 Когда у конфигурации стоит полная поддержка, общий статус у неё 1, а не 0.
There was a problem hiding this comment.
0 становится после жмаканья кнопки "Включить возможность изменения".
There was a problem hiding this comment.
я как раз хотел предложить ввести отдельный энум/константу
There was a problem hiding this comment.
@theshadowco @otymko Константа или enum?
There was a problem hiding this comment.
@theshadowco @otymko добавил enum
otymko
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #134