Skip to content

[SC-1435] Fix Create3 deployment saving on contract source code verification failure #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2025
Merged

[SC-1435] Fix Create3 deployment saving on contract source code verification failure #179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,15 +218,6 @@ export async function saveContractWithCreate3Deployment(
['provider', 'blobGasPrice', 'type', 'root', 'hash', 'index'].forEach(key => delete receipt[key]);
}

if (!(skipVerify || constants.DEV_CHAINS.includes(hre.network.name))) {
await hre.run('verify:verify', {
address: contract,
constructorArguments: constructorArgs,
});
} else {
console.log('Skipping verification');
}

const ContractArtifact = await deployments.getArtifact(contractName);
const ContractDeploymentData = {} as Deployment;
ContractDeploymentData.address = contract;
Expand All @@ -237,6 +228,16 @@ export async function saveContractWithCreate3Deployment(
ContractDeploymentData.bytecode = ContractArtifact.bytecode;
ContractDeploymentData.deployedBytecode = ContractArtifact.deployedBytecode;
await deployments.save(deploymentName, ContractDeploymentData);

if (!(skipVerify || constants.DEV_CHAINS.includes(hre.network.name))) {
await hre.run('verify:verify', {
address: contract,
constructorArguments: constructorArgs,
});
} else {
console.log('Skipping verification');
}

return await ethers.getContractAt(contractName, contract);
}

Expand Down
Loading