Conversation
Contributor
Author
|
@twarnock2w Should be all set! |
twarnock
approved these changes
Jun 14, 2019
Contributor
twarnock
left a comment
twarnock
left a comment
There was a problem hiding this comment.
Obviously did not have time to review logic, but the code looks good based on some spot checking. Love the consistent use of f-strings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to implement a fairly pointed use-case allowing for the user to interactively step through using CloudEndure to launch test instances of replicated servers and use those target instances to peel off AMIs and share them across assumable accounts in AWS. This allows for further interactive and automated migrations without using cloudendure's blueprints as the final source of truth.
Additionally, and probably more importantly... this allows you to pick up in Terraform where you leave off here versus being locked into blueprints.